-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit_extern_abis
Feature and Enforce Explicit ABIs
#135340
base: master
Are you sure you want to change the base?
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustfmt changes look good 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to mark style edition 2027 as unstable, @ytmimi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally right. I take back what I said 😅
This comment has been minimized.
This comment has been minimized.
938c721
to
b327d2d
Compare
This comment has been minimized.
This comment has been minimized.
I do not think we will accept the edition changes being folded into this PR, @obeis |
b327d2d
to
e25d0af
Compare
#[value = "2027"] | ||
#[doc_hint = "2027"] | ||
/// [Edition 2027](). | ||
Edition2027, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @compiler-errors mentioned, we'd need to mark this as an unstable option in rustfmt.
#[value = "2027"] | |
#[doc_hint = "2027"] | |
/// [Edition 2027](). | |
Edition2027, | |
#[value = "2027"] | |
#[doc_hint = "2027"] | |
#[unstable_variant] | |
/// [Edition 2027](). | |
Edition2027, |
Though, If we're not moving forward with the edition
implementation in this PR, then we can revert these rustfmt changes since we've already got an unstable 2027 style edition implemented in the upstream rustfmt
e25d0af
to
20f28b1
Compare
This comment has been minimized.
This comment has been minimized.
fe8b62b
to
bc8ed0e
Compare
This comment has been minimized.
This comment has been minimized.
bc8ed0e
to
e1db710
Compare
This PR modifies cc @jieyouxu |
Introduces the unstable
explicit_extern_abis
feature, requiring explicit ABIs in extern blocks. Hard errors are enforced with the feature enabled, and the 2027 edition prepares for full adoption.RFC rust-lang/rfcs#3722
Update #134986