Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-builtins to 0.1.141 #135180

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jan 7, 2025

0.1.141 syncs changes from libm. Most of the libm changes are testing- or configuration-related.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@tgross35
Copy link
Contributor Author

tgross35 commented Jan 7, 2025

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@tgross35
Copy link
Contributor Author

tgross35 commented Jan 7, 2025

r? @ghost 🙃

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@tgross35
Copy link
Contributor Author

tgross35 commented Jan 7, 2025

Sorry for the noise Boxy

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 7, 2025

lmao

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 7, 2025

bors is such a fussy bot

@tgross35
Copy link
Contributor Author

tgross35 commented Jan 7, 2025

@bors r+ rollup=never (libm config is arch-dependent)

@bors
Copy link
Contributor

bors commented Jan 7, 2025

📌 Commit 6ac74e1 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2025
@bors
Copy link
Contributor

bors commented Jan 7, 2025

⌛ Testing commit 6ac74e1 with merge a2d9f0b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2025
Update compiler-builtins to 0.1.141

0.1.141 syncs changes from `libm`. Most of the `libm` changes are testing- or configuration-related.
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 7, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2025
@tgross35
Copy link
Contributor Author

tgross35 commented Jan 8, 2025

I don't understand why diagnostics in a UI test would be providing suggestions from compiler_builtins, asking about this on Zulip https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Compiletest.3A.20why.20is.20.60compiler_builtins.60.20in.20scope.3F.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

HIR ty lowering was modified

cc @fmease

@tgross35 tgross35 marked this pull request as draft January 14, 2025 02:23
@bors
Copy link
Contributor

bors commented Jan 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2025
@tgross35
Copy link
Contributor Author

re-rebased to include a fix

@bors try

@bors
Copy link
Contributor

bors commented Jan 14, 2025

⌛ Trying commit 23d1ef1 with merge 499fe89...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2025
Update compiler-builtins to 0.1.141

0.1.141 syncs changes from `libm`. Most of the `libm` changes are testing- or configuration-related.

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 14, 2025

💔 Test failed - checks-actions

@tgross35
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2025
Update compiler-builtins to 0.1.141

INCLUDES EXPERIMENT, DO NOT MERGE

0.1.141 syncs changes from `libm`. Most of the `libm` changes are testing- or configuration-related.

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jan 14, 2025

⌛ Trying commit f662149 with merge 39066dc...

@bors
Copy link
Contributor

bors commented Jan 14, 2025

☀️ Try build successful - checks-actions
Build commit: 39066dc (39066dc20a1328b63348468f4401fae3a82be09a)

0.1.141 syncs changes from `libm`. Most of the `libm` changes are
testing- or configuration-related.
@tgross35 tgross35 marked this pull request as ready for review January 14, 2025 18:43
@tgross35
Copy link
Contributor Author

The fix merged, so this should be unblocked.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2025

📌 Commit fcc34b2 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2025
@bors
Copy link
Contributor

bors commented Jan 14, 2025

⌛ Testing commit fcc34b2 with merge dd333ca...

@bors
Copy link
Contributor

bors commented Jan 15, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing dd333ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 15, 2025
@bors bors merged commit dd333ca into rust-lang:master Jan 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 15, 2025
@tgross35 tgross35 deleted the update-builtins branch January 15, 2025 03:03
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dd333ca): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -4.3%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
-4.3% [-5.9%, -2.7%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.3% [-5.9%, -2.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.183s -> 763.632s (0.19%)
Artifact size: 326.05 MiB -> 326.08 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants