Skip to content

Add FileCheck annotations to mir-opt/copy-prop #135099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 3, 2025
Merged

Add FileCheck annotations to mir-opt/copy-prop #135099

merged 14 commits into from
Nov 3, 2025

Conversation

@Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Jan 4, 2025

This resolves a part of #116971 .

This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2025
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
@Shunpoco Shunpoco marked this pull request as ready for review January 4, 2025 13:16
@Shunpoco
Copy link
Contributor Author

Shunpoco commented Jan 4, 2025

r? @cjgillot

@rustbot rustbot assigned cjgillot and unassigned Mark-Simulacrum Jan 4, 2025
cjgillot
cjgillot reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great work. A few nits.

@apiraino
Copy link
Contributor

apiraino commented Apr 8, 2025

r? compiler

@rustbot rustbot assigned BoxyUwU and unassigned cjgillot Apr 8, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 8, 2025

r? @jieyouxu
weird test stuff

@rustbot rustbot assigned jieyouxu and unassigned BoxyUwU Apr 8, 2025
jieyouxu
jieyouxu reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FileCheck annotations syntactically look okay but I don't know mir-opts well so rerolling a mir-opt reviewer.

@jieyouxu
Copy link
Member

jieyouxu commented Apr 8, 2025

r? mir-opt

@rustbot rustbot assigned wesleywiser and unassigned jieyouxu Apr 8, 2025
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc A-mir-opt Area: MIR optimizations labels Apr 8, 2025
wesleywiser
wesleywiser reviewed Apr 18, 2025
View reviewed changes
@wesleywiser
Copy link
Member

wesleywiser commented Oct 16, 2025

r? rust-lang/compiler

@rustbot rustbot assigned davidtwco and unassigned wesleywiser Oct 16, 2025
davidtwco
davidtwco approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, replied to another review comment then r=me

View changes since this review

@Shunpoco Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from 7a64137 to b30493b Compare October 26, 2025 10:38
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 26, 2025 •
edited
Loading

Can you please squash or otherwise reorganize the commits a bit? 20+ commits seems unnecessary.

@Shunpoco Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from b30493b to 620b9b1 Compare October 26, 2025 10:59
@davidtwco
Copy link
Member

davidtwco commented Nov 3, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2025

📌 Commit 620b9b1 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 3, 2025
Merged
bors added a commit that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148446 - GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
1f880d9 
Rollup of 8 pull requests

Successful merges:

 - #135099 (Add FileCheck annotations to mir-opt/copy-prop)
 - #145903 (Give correct suggestion for a typo in raw pointers)
 - #147520 (Port the remaining SIMD intrinsics to const-eval)
 - #148068 (rustdoc: Use configured target modifiers when collecting doctests)
 - #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
 - #148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
 - #148306 (Remove double check when decoding ExpnId to avoid races)
 - #148378 (Fix documentation for std::panic::update_hook)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c97bde7 into rust-lang:master Nov 3, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 3, 2025
rust-timer added a commit that referenced this pull request Nov 3, 2025
@rust-timer
Unrolled build for #135099
e096d76 
Rollup merge of #135099 - Shunpoco:116971-mir-opt-copy-prop, r=davidtwco

Add FileCheck annotations to mir-opt/copy-prop

This resolves a part of #116971 .

This PR adds FileCheck annotations to test files under mir-opt/copy-prop.
@Shunpoco Shunpoco deleted the 116971-mir-opt-copy-prop branch November 3, 2025 19:55
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148446 - GuillaumeGomez:rollup-lxwlqol, r=GuillaumeGomez
a2f0023 
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#135099 (Add FileCheck annotations to mir-opt/copy-prop)
 - rust-lang/rust#145903 (Give correct suggestion for a typo in raw pointers)
 - rust-lang/rust#147520 (Port the remaining SIMD intrinsics to const-eval)
 - rust-lang/rust#148068 (rustdoc: Use configured target modifiers when collecting doctests)
 - rust-lang/rust#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
 - rust-lang/rust#148268 (rustdoc: fix `--emit=dep-info` on scraped examples)
 - rust-lang/rust#148306 (Remove double check when decoding ExpnId to avoid races)
 - rust-lang/rust#148378 (Fix documentation for std::panic::update_hook)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser left review comments

@cjgillot cjgillot cjgillot left review comments

@jieyouxu jieyouxu jieyouxu left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-mir-opt Area: MIR optimizations A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Shunpoco @rustbot @apiraino @BoxyUwU @jieyouxu @wesleywiser @davidtwco @bors @cjgillot @Mark-Simulacrum