Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement int_from_ascii (#134821) #134824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Dec 27, 2024

Provides unstable T::from_ascii() and T::from_ascii_radix() for integer types T, as drafted in tracking issue #134821.

To deduplicate documentation without additional macros, implementations of isize and usize no longer delegate to equivalent integer types. After #132870 they are inlined anyway.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 27, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Provides unstable `T::from_ascii()` and `T::from_ascii_radix()` for integer
types `T`, as drafted in tracking issue rust-lang#134821.

To deduplicate documentation without additional macros, implementations of
`isize` and `usize` no longer delegate to equivalent integer types.
After rust-lang#132870 they are inlined anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants