-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Stabilize the cell_update
feature
#134446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @workingjubilee. Use |
The Miri subtree was changed cc @rust-lang/miri |
There was some continued discussion on the thread after FCP started. I don't think anything changed, but I'll request libs-api take a look to double check. r? libs-api |
Should we maybe change the signature from pub fn update<F>(&self, f: F) -> T
where
F: FnOnce(T) -> T, to pub fn update(&self, f: impl FnOnce(T) -> T) -> T analogous to #135956? |
☔ The latest upstream changes (presumably #135937) made this pull request unmergeable. Please resolve the merge conflicts. |
Nominating for libs-api to:
@rustbot label +I-libs-api-nominated |
We discussed this in the @rust-lang/libs-api meeting last week and the conclusion was that:
Once those changes are made we will re-start the FCP for stabilization. |
6957c85
to
db8f5eb
Compare
Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
Thanks for taking a look. I'll leave this PR for stabilization only, API updates are in #139273. |
…pratt Apply requested API changes to `cell_update` Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
…pratt Apply requested API changes to `cell_update` Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
Rollup merge of rust-lang#139273 - tgross35:cell-update-changes, r=jhpratt Apply requested API changes to `cell_update` Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
Included API: impl<T: Copy> Cell<T> { pub fn update(&self, f: impl FnOnce(T) -> T); } Closes: rust-lang#50186
db8f5eb
to
ac34a6f
Compare
@Amanieu this should be ready for FCP now. |
@rfcbot merge |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
…pratt Apply requested API changes to `cell_update` Do the following: * Switch to `impl FnOnce` rather than a generic `F`. * Change `update` to return nothing. This was discussed at a libs-api meeting [1]. Tracking issue: rust-lang#50186 [1]: rust-lang#134446 (comment)
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
libs-api completed FCP so this just needs libs review r? libs |
r? jhpratt @bors r+ rollup |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#134446 (Stabilize the `cell_update` feature) - rust-lang#139307 (std: Add performance warnings to HashMap::get_disjoint_mut) - rust-lang#139450 (Impl new API `std::os::unix::fs::mkfifo` under feature `unix_fifo`) - rust-lang#139809 (Don't warn about `v128` in wasm ABI transition) - rust-lang#139852 (StableMIR: Implement `CompilerInterface`) - rust-lang#139945 (Extend HIR to track the source and syntax of a lifetime) - rust-lang#140028 (`deref_patterns`: support string and byte string literals in explicit `deref!("...")` patterns) - rust-lang#140181 (Remove `synstructure::Structure::underscore_const` calls.) - rust-lang#140232 (Remove unnecessary clones) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134446 - tgross35:stabilize-cell_update, r=jhpratt Stabilize the `cell_update` feature Included API: ```rust impl<T: Copy> Cell<T> { pub fn update(&self, f: impl FnOnce(T) -> T); } ``` FCP completed once at rust-lang#50186 (comment) but the signature has since changed. Closes: rust-lang#50186
Included API:
FCP completed once at #50186 (comment) but the signature has since changed.
Closes: #50186