run-make: Fix assert_stderr_not_contains_regex
#134113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It asserted on **stdout**, not stderr.
rustbot
added
A-run-make
|
The run-make-support library was changed cc @jieyouxu |
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
Actually one sec let me just run this locally, lol. @bors r- |
bors
added
S-waiting-on-author
|
Works on my Machine:tm: |
bors
added
S-waiting-on-bors
jieyouxu
added
the
A-testsuite
fmease
added a commit
to fmease/rust
that referenced
this pull request
Dec 10, 2024
run-make: Fix `assert_stderr_not_contains_regex` It asserted on **stdout**, not stderr. r? `@jieyouxu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#133583 (Fix type (exit → exist)) - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#133583 (Fix type (exit → exist)) - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#133583 (Fix type (exit → exist)) - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
Rollup merge of rust-lang#134113 - jyn514:run-make-contains, r=jieyouxu run-make: Fix `assert_stderr_not_contains_regex` It asserted on **stdout**, not stderr. r? ``@jieyouxu``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It asserted on stdout, not stderr.
r? @jieyouxu