[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

lcnr · 2024-11-26T15:26:47Z

A revival of #124812. See the Tracking Issue for -Znext-solver. Current status:

~~./x.py b --stage 2 passes 🎉~~

try builds succeed 🎉 🎉 🎉

crater

This does not detect hangs or memory issues.

date	#crates	#regressions
2025.04.11	100	2
2025.04.11	1000	27
2025.04.17	10000	456
2025.04.18	10000	437
2025.04.24	10000	164
2025.04.26	10000	108
2025.04.28	10000	91
2025.05.01	10000	145 woops
2025.05.03	624228¹	1585
2025.05.05	8964²	931
2025.05.06	4401²	726
2025.05.07	2704²	668
2025.05.09	2345²	664
2025.09.20	701952¹	4739 + 7039 spurious

in-flight changes

r? @ghost

a complete crater run ↩ ↩²
only testing crates which may have regressed from the above run ↩ ↩² ↩³ ↩⁴

compiler-errors · 2024-11-27T04:03:51Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status, we're failing in: - failing in `rustc_next_trait_solver` with 126 instances of the following error ``` error[E0311]: the parameter type `I` may not live long enough | help: consider adding an explicit lifetime bound --> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:624:53 | 624 ~ fn consider_structural_builtin_unsize_candidates<'a>( 625 ~ ecx: &mut EvalCtxt<'a, D>, 626 | goal: Goal<I, Self>, 627 ~ ) -> Vec<Candidate<I>> where I: 'a { ``` - `itertools` hangs, we're already encountered this hang in our previous attempt due to large type sizes. I believe that it's simply caused by a missing cache somewhere, potentially in `wf.rs`, but other visitors may also be responsible. See rust-itertools/itertools#945 for more details ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now r? `@ghost`

bors · 2024-11-27T04:05:03Z

⌛ Trying commit f631ca8 with merge ca04381...

compiler-errors · 2024-11-27T04:05:17Z

I also pushed:

I think this is sufficient to make the compiler build, or at least ./x.py build --stage=2 completes successfully on my local branch.

bors · 2024-11-27T06:15:40Z

💔 Test failed - checks-actions

bors · 2024-11-27T10:43:04Z

☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts.

lqd · 2024-11-27T11:42:49Z

Next failure is on color-print-proc-macro-0.3.6 while building cargo.

pub fn repro() -> impl FnMut() {
    if true {
        || ()
    } else {
        || ()
    }
}

godbolt

compiler-errors · 2024-11-27T17:49:50Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T17:51:02Z

⌛ Trying commit 6210ed3 with merge ac5ccad...

bors · 2024-11-27T20:03:42Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-27T20:15:22Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T20:16:33Z

⌛ Trying commit 8fa8f40 with merge 550ae0d...

lqd · 2024-11-27T20:26:10Z

I was reducing the new failure but you've already fixed it ^^

bors · 2025-09-26T19:39:47Z

☔ The latest upstream changes (presumably #146885) made this pull request unmergeable. Please resolve the merge conflicts.

…pre-fallback where we equate hidden types but do not report errors

lcnr · 2025-10-01T09:16:27Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

rust-log-analyzer · 2025-10-01T09:21:42Z

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
[TIMING:end] tool::ToolBuild { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [], artifact_kind: Binary } -- 11.103
[TIMING:end] tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/compiler/rustc_hir_typeck/src/opaque_types.rs:252:
         for &(key, hidden_type) in opaque_types {
             // On the first pass to this function, some opaque types may not
             // have a hidden type assigned.
-            if let Some(expected) =
-                self.typeck_results.borrow_mut().hidden_types.get(&key.def_id)
-            {
+            if let Some(expected) = self.typeck_results.borrow_mut().hidden_types.get(&key.def_id) {
                 let expected = EarlyBinder::bind(expected.ty).instantiate(tcx, key.args);
                 self.demand_eqtype(hidden_type.span, expected, hidden_type.ty);
             }
fmt: checked 6440 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:00:48
  local time: Wed Oct  1 09:21:30 UTC 2025

rust-bors · 2025-10-01T11:29:30Z

☀️ Try build successful (CI)
Build commit: 50ad67a (50ad67a27001e22f9b432d691931e444a2065c57, parent: 1e1a39441bd11aba541a48ba714d939490fc7b85)

lcnr · 2025-10-01T11:43:51Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-133502-14/retry-regressed-list.txt p=1

craterbot · 2025-10-01T11:43:57Z

👌 Experiment pr-133502-15 created and queued.
🤖 Automatically detected try build 50ad67a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 26, 2024

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the rust4 branch from c3ef9cd to f631ca8 Compare November 27, 2024 04:03

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2024

compiler-errors force-pushed the rust4 branch from f631ca8 to 6210ed3 Compare November 27, 2024 17:49

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the rust4 branch from 6210ed3 to 8fa8f40 Compare November 27, 2024 20:15

This comment has been minimized.

Sign in to view

craterbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2025

lcnr force-pushed the rust4 branch from 22389a5 to d13c060 Compare September 24, 2025 09:04

This comment has been minimized.

Sign in to view

lcnr force-pushed the rust4 branch from d13c060 to ea80464 Compare September 24, 2025 12:53

This comment has been minimized.

Sign in to view

lcnr mentioned this pull request Sep 24, 2025

remove reliance on a trait solver inference bug GlareDB/glaredb#4033

Open

lcnr force-pushed the rust4 branch from ea80464 to 625a689 Compare September 26, 2025 11:58

This comment has been minimized.

Sign in to view

lcnr and others added 3 commits October 1, 2025 11:00

obligations_for_self_ty: skip irrelevant goals

9a945cb

also filter obligations by sub_root

c76f20c

instantiate predicate binder without recanonicalizing goal in new solver

ab2d5bc

lcnr force-pushed the rust4 branch from 625a689 to 9951a99 Compare October 1, 2025 09:02

lcnr and others added 5 commits October 1, 2025 11:12

-Znext-solver: slightly strenghten closure sig inference

c2a3f26

Split Bound into Canonical and Bound

7a643b5

When computing opaque types in the next solver, take an initial pass …

978574a

…pre-fallback where we equate hidden types but do not report errors

enable -Znext-solver by default

a905096

w

7dc9986

lcnr force-pushed the rust4 branch from e60abaf to 7dc9986 Compare October 1, 2025 09:12

rustbot added the T-clippy Relevant to the Clippy team. label Oct 1, 2025

w

6ce0e88

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Oct 1, 2025

Auto merge of #133502 - lcnr:rust4, r=<try>

50ad67a

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Are you sure you want to change the base?

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Conversation

lcnr commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

crater

in-flight changes

Footnotes

Uh oh!

This comment has been minimized.

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

This comment was marked as off-topic.

This comment has been minimized.

bors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

lqd commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Nov 27, 2024

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

lqd commented Nov 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Sep 26, 2025

Uh oh!

lcnr commented Oct 1, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 1, 2025

Uh oh!

rust-bors bot commented Oct 1, 2025

Uh oh!

lcnr commented Oct 1, 2025

Uh oh!

craterbot commented Oct 1, 2025

Uh oh!

Uh oh!

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

lcnr commented Nov 26, 2024 •

edited

Loading

lqd commented Nov 27, 2024 •

edited

Loading