Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle separate prefixes in clippy rules #132873

Merged
merged 2 commits into from
Nov 11, 2024
Merged

handle separate prefixes in clippy rules #132873

merged 2 commits into from
Nov 11, 2024

Conversation

onur-ozkan
Copy link
Member

Fixes #132867

@onur-ozkan
handle separate prefixes in clippy args
6643586 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add test coverage for separate clippy prefixes
469c8ba 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

jieyouxu
jieyouxu reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a question, but the fix itself is very reasonable to me.

src/bootstrap/src/core/build_steps/clippy.rs Show resolved Hide resolved
jieyouxu
jieyouxu approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself is not related to lint level flag ordering, so this otherwise LGTM.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 11, 2024

📌 Commit 469c8ba has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@bors
Auto merge of rust-lang#132902 - matthiaskrgr:rollup-43qgg3t, r=matth…
2d8ab22 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#129627 (Ensure that tail expr receive lifetime extension)
 - rust-lang#130999 (Implement file_lock feature)
 - rust-lang#132873 (handle separate prefixes in clippy rules)
 - rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@bors
Auto merge of rust-lang#132902 - matthiaskrgr:rollup-43qgg3t, r=matth…
81eef2d 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#129627 (Ensure that tail expr receive lifetime extension)
 - rust-lang#130999 (Implement file_lock feature)
 - rust-lang#132873 (handle separate prefixes in clippy rules)
 - rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7319666 into rust-lang:master Nov 11, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@rust-timer
Unrolled build for rust-lang#132873
20a194e 
Rollup merge of rust-lang#132873 - onur-ozkan:132867, r=jieyouxu

handle separate prefixes in clippy rules

Fixes rust-lang#132867
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
@matthiaskrgr @mati865
Rollup merge of rust-lang#132873 - onur-ozkan:132867, r=jieyouxu
c365903 
handle separate prefixes in clippy rules

Fixes rust-lang#132867
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
@bors @mati865
Auto merge of rust-lang#132902 - matthiaskrgr:rollup-43qgg3t, r=matth…
cc1bfd8 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#129627 (Ensure that tail expr receive lifetime extension)
 - rust-lang#130999 (Implement file_lock feature)
 - rust-lang#132873 (handle separate prefixes in clippy rules)
 - rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)

r? `@ghost`
`@rustbot` modify labels: rollup
@onur-ozkan onur-ozkan deleted the 132867 branch November 12, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.

./x clippy errors if lint levels are passed as multiple arguments
4 participants
@onur-ozkan @rustbot @jieyouxu @bors