compiler: Directly use rustc_abi almost everywhere #132574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in cc @BoxyUwU These commits modify the If this was unintentional then you should revert the changes before this PR is merged. This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri HIR ty lowering was modified cc @fmease Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred in exhaustiveness checking cc @Nadrieril |
|
...Good afternoon, T-compiler! |
RalfJung
reviewed
Nov 3, 2024
This comment has been minimized.
This comment has been minimized.
| @@ -166,13 +163,13 @@ impl Primitive { | |||
| #[inline] | |||
| fn to_int_ty<'tcx>(&self, tcx: TyCtxt<'tcx>) -> Ty<'tcx> { | |||
| match *self { | |||
| Int(i, signed) => i.to_ty(tcx, signed), | |||
| Primitive::Int(i, signed) => i.to_ty(tcx, signed), | |||
There was a problem hiding this comment.
were these glob imported previously? are they no longer?
There was a problem hiding this comment.
Yes. Wait, no, lol.
compiler-errors
approved these changes
Nov 3, 2024
Stop reexporting ReprOptions from middle::ty
workingjubilee
force-pushed
the
abi-in-compiler
branch
from
694b5f2
to
fa20473
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#126136 (Call the target libdir target libdir) - rust-lang#132516 (Add bad-reg inline assembly ui test for RISC-V and s390x) - rust-lang#132521 (replace manual time convertions with std ones, comptime time format parsing) - rust-lang#132560 (Remove outdated tidy license fixmes) - rust-lang#132563 (Modify `NonZero` documentation to reference the underlying integer type) - rust-lang#132574 (compiler: Directly use rustc_abi almost everywhere) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
Rollup merge of rust-lang#132574 - workingjubilee:abi-in-compiler, r=compiler-errors compiler: Directly use rustc_abi almost everywhere Use rustc_abi instead of rustc_target where applicable. This is mostly described by the following substitutions: ```rust match path_substring { rustc_target::spec::abi::Abi => rustc_abi::ExternAbi, rustc_target::abi::call => rustc_target::callconv, rustc_target::abi => rustc_abi, } ``` A number of spot-fixes make that not quite the whole story. The main exception is in 33edc68 where I get a lot more persnickety about how things are imported, especially in `rustc_middle::ty::layout`, not just from where. This includes putting an end to a reexport of `rustc_middle::ty::ReprOptions`, for the same reason that the rest of this change is happening: reexports mostly confound things. This notably omits rustc_passes and the ast crates, as I'm still examining a question I have about how they do stability checking of `extern "Abi"` strings and if I can simplify their logic. The rustc_abi and rustc_target crates also go untouched because they will be entangled in that cleanup. r? compiler-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rustc_abi instead of rustc_target where applicable. This is mostly described by the following substitutions:
A number of spot-fixes make that not quite the whole story.
The main exception is in 236fe33 where I get a lot more persnickety about how things are imported, especially in
rustc_middle::ty::layout, not just from where. This includes putting an end to a reexport ofrustc_middle::ty::ReprOptions, for the same reason that the rest of this change is happening: reexports mostly confound things.This notably omits rustc_passes and the ast crates, as I'm still examining a question I have about how they do stability checking of
extern "Abi"strings and if I can simplify their logic. The rustc_abi and rustc_target crates also go untouched because they will be entangled in that cleanup.r? compiler-errors