-
Notifications
You must be signed in to change notification settings - Fork 13.3k
PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b #132419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
5762031
to
052ca60
Compare
We don't see a reason to explicitly pass the default here, so just use the default instead of explicitly passing it and needing an ifdef. @rustbot label: +llvm-main
052ca60
to
ab5583e
Compare
Thanks! @bors r+ rollup |
This one has been in a handful of rollups that failed for mysterious reasons during LLVM phases (PGO, etc.) and it's not ifdef'd to only affect @bors rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (db034ce): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.2%, secondary 3.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 780.951s -> 779.49s (-0.19%) |
A boolean turned into an enum. None matches the old behavior of false, so we pass that.
@rustbot label: +llvm-main