Skip to content

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b #132419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Oct 31, 2024

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

@rustbot label: +llvm-main

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Oct 31, 2024
@rust-log-analyzer

This comment has been minimized.

@durin42 durin42 force-pushed the llvm-20-type-test-thing branch from 5762031 to 052ca60 Compare October 31, 2024 18:57
We don't see a reason to explicitly pass the default here, so just use
the default instead of explicitly passing it and needing an ifdef.

@rustbot label: +llvm-main
@durin42 durin42 force-pushed the llvm-20-type-test-thing branch from 052ca60 to ab5583e Compare November 2, 2024 18:40
@cuviper
Copy link
Member

cuviper commented Nov 2, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 2, 2024

📌 Commit ab5583e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024
@workingjubilee
Copy link
Member

workingjubilee commented Nov 3, 2024

This one has been in a handful of rollups that failed for mysterious reasons during LLVM phases (PGO, etc.) and it's not ifdef'd to only affect LLVM_VERSION_MAJOR >= 20, so I'm being over-cautious and marking this

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Nov 3, 2024

⌛ Testing commit ab5583e with merge db034ce...

@bors
Copy link
Collaborator

bors commented Nov 3, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing db034ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2024
@bors bors merged commit db034ce into rust-lang:master Nov 3, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 3, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (db034ce): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.2%, secondary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)
3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)
-3.9% [-3.9%, -3.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-3.9%, 3.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.951s -> 779.49s (-0.19%)
Artifact size: 335.37 MiB -> 335.37 MiB (-0.00%)

@durin42 durin42 deleted the llvm-20-type-test-thing branch December 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants