Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code stemming from the old effects desugaring #132374

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove dead code stemming from the old effects desugaring #132374

merged 1 commit into from
Oct 31, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Oct 30, 2024

r? project-const-traits

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024
@fmease fmease changed the title Remove dead code from the old effects desugaring Remove dead code stemming from the old effects desugaring Oct 30, 2024
@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 30, 2024
compiler-errors
compiler-errors approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 30, 2024

📌 Commit a6bbdf0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
@bors
Auto merge of rust-lang#132377 - matthiaskrgr:rollup-3p1c6hs, r=matth…
75eff9a 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132368 (Remove `do_not_const_check` from `Iterator` methods)
 - rust-lang#132373 (Make sure `type_param_predicates` resolves correctly for RPITIT)
 - rust-lang#132374 (Remove dead code stemming from the old effects desugaring)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d0dbc5 into rust-lang:master Oct 31, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
@rust-timer
Unrolled build for rust-lang#132374
260bc6e 
Rollup merge of rust-lang#132374 - fmease:rm-dead-eff-code, r=compiler-errors

Remove dead code stemming from the old effects desugaring

r? project-const-traits
@rustbot rustbot added this to the 1.84.0 milestone Oct 31, 2024
@fmease fmease deleted the rm-dead-eff-code branch October 31, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fmease @compiler-errors @bors @fee1-dead @rustbot