Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that raw lifetimes must be valid raw identifiers #132363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enforce that raw lifetimes must be valid raw identifiers #132363

wants to merge 1 commit into from
+72 −4

Conversation

compiler-errors
Copy link
Member

Make sure that the identifier part of a raw lifetime is a valid raw identifier. This precludes 'r#_ and all module segment paths for now.

I don't believe this is compelling to support. This was raised by @ehuss in rust-lang/reference#1603 (comment) (well, specifically the 'r#_ case), but I don't see why we shouldn't just make it consistent with raw identifiers.

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024
@compiler-errors compiler-errors added beta-nominated Nominated for backporting to the compiler in the beta channel. I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024
@compiler-errors
Copy link
Member Author

Nominating for T-lang once again, seems like an easy decision b/c it's just slighlty paring back the generality of a new feature stabilized in the next rust version. For that reason I'm also beta nominating it, just like ##132341.

@nikomatsakis
Copy link
Contributor

@rustbot labels +T-lang

@rustbot rustbot added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Oct 30, 2024
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Oct 30, 2024 •
edited
Loading

@rfcbot fcp merge

Consistency across classes of identifiers seems correct.

@rfcbot
Copy link

rfcbot commented Oct 30, 2024 •
edited
Loading

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 30, 2024
@traviscross
Copy link
Contributor

@rfcbot reviewed

1 similar comment
@scottmcm
Copy link
Member

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 30, 2024
@rfcbot
Copy link

rfcbot commented Oct 30, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@tmandry
Copy link
Member

tmandry commented Oct 30, 2024

@rfcbot reviewed

@traviscross traviscross removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Oct 30, 2024
@traviscross
Copy link
Contributor

@rustbot labels -I-lang-nominated

We discussed this in triage today, and as above, we liked this. We could always decide to allow more later. Being consistent and conservative seems right for now.

wesleywiser
wesleywiser approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when FCP has appropriately completed 🙂

@compiler-errors compiler-errors added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@compiler-errors @rustbot @nikomatsakis @rfcbot @traviscross @scottmcm @tmandry @wesleywiser