Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #132269

Closed
wants to merge 13 commits into from
Closed

Rollup of 5 pull requests #132269

wants to merge 13 commits into from
+349 −270

Commits on Oct 28, 2024

  1. stable_mir: Directly use types from rustc_abi

    @workingjubilee
    workingjubilee committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d216d6a View commit details
    Browse the repository at this point in the history

  2. Lower AST node id only once

    @adwinwhite
    adwinwhite committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cb08e08 View commit details
    Browse the repository at this point in the history

  3. Add duplicate lowering check

    @adwinwhite
    adwinwhite committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1a39247 View commit details
    Browse the repository at this point in the history

  4. more consistent debug_assertions

    @adwinwhite
    adwinwhite committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e3bf50e View commit details
    Browse the repository at this point in the history

  5. Unify variant struct fields margins with struct fields

    @GuillaumeGomez
    GuillaumeGomez committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7cfbe23 View commit details
    Browse the repository at this point in the history

  6. Add GUI regression test for variant structfields margins

    @GuillaumeGomez
    GuillaumeGomez committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    26b6ccd View commit details
    Browse the repository at this point in the history

  7. Use a type-safe helper to cast &str and &[u8] to *const c_char

    @Zalathar
    Zalathar committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4bd84b2 View commit details
    Browse the repository at this point in the history

  8. refactor: cleaner check to return None

    @ChrisCho-H
    ChrisCho-H committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    82bfe05 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#130259 - adwinwhite:lower-node-id-once, r=c… 

    …jgillot

Lower AST node id only once

Fixes rust-lang#96346.

I basically followed the given instructions except the inline part.

`lower_jump_destination` can't reuse local existing `HirId` due to unknown name resolution result so I created an additional mapping for labels.

r? `@cjgillot`
    @GuillaumeGomez
    GuillaumeGomez authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    93dd589 View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#132247 - workingjubilee:add-rustc-abi-to-sm… 

    …ir, r=celinval

stable_mir: Directly use types from rustc_abi

In most cases, rustc_target is not necessary, so use rustc_abi instead of its reexports.
    @GuillaumeGomez
    GuillaumeGomez authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    83ea825 View commit details
    Browse the repository at this point in the history

  11. Rollup merge of rust-lang#132258 - GuillaumeGomez:variant-structfield… 

    …s-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? `@notriddle`
    @GuillaumeGomez
    GuillaumeGomez authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f0f1127 View commit details
    Browse the repository at this point in the history

  12. Rollup merge of rust-lang#132260 - Zalathar:type-safe-cast, r=compile… 

    …r-errors

cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`

In `rustc_codegen_llvm` there are many uses of `.as_ptr().cast()` to convert a string or byte-slice to `*const c_char`, which then gets passed through FFI.

This works, but is fragile, because there's nothing constraining the pointer cast to actually be from `u8` to `c_char`. If the original value changes to something else that has an `as_ptr` method, or the context changes to expect something other than `c_char`, the cast will silently do the wrong thing.

By making the cast more explicit via a helper method, we can be sure that it will either perform the intended cast, or fail at compile time.
    @GuillaumeGomez
    GuillaumeGomez authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4a907c1 View commit details
    Browse the repository at this point in the history

  13. Rollup merge of rust-lang#132261 - ChrisCho-H:refactor/cleaner-check-… 

    …none, r=compiler-errors

refactor: cleaner check to return None

It's very nit change. Refactor to shorten verbose check when returning None for `backend_feature_name`.
    @GuillaumeGomez
    GuillaumeGomez authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    09417c7 View commit details
    Browse the repository at this point in the history