Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Oct 25, 2024

This lets us remove a hack from #131349.

r? @Amanieu

try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 25, 2024
@Amanieu
Copy link
Member

Amanieu commented Oct 25, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

📌 Commit 80019ca has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2024
@RalfJung
Copy link
Member Author

@bors rollup=iffy

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
bump stdarch

This lets us remove a hack from rust-lang#131349.

r? `@Amanieu`
@bors
Copy link
Collaborator

bors commented Oct 25, 2024

⌛ Testing commit 80019ca with merge c5f6631...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2024
@RalfJung
Copy link
Member Author

Damn, looks like we have to land #131349 first...

Cc @compiler-errors

@RalfJung
Copy link
Member Author

Testing whether rust-lang/stdarch#1660 suffices to fix this.
@bors try

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

⌛ Trying commit 7a48daf with merge 939b3b4...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
bump stdarch

This lets us remove a hack from rust-lang#131349.

r? `@Amanieu`

try-job: test-various
@compiler-errors
Copy link
Contributor

Merge this into that PR, perhaps? Or does it need to happen before?

@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Having a stdarch update together with another big change does not sound great.

@RalfJung
Copy link
Member Author

@bors try

@rust-log-analyzer

This comment was marked as outdated.

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

⌛ Trying commit 97a08ca with merge 6b2bf50...

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

☀️ Try build successful - checks-actions
Build commit: 6b2bf50 (6b2bf5054433231c632c2eaed8f6b984d9d806ed)

@Amanieu
Copy link
Member

Amanieu commented Oct 28, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

📌 Commit bf0ae21 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Collaborator

bors commented Oct 28, 2024

⌛ Testing commit bf0ae21 with merge 71ada1d...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2024
@RalfJung
Copy link
Member Author

Some more rustc_const_stable that are not actually stable in in cfg'd parts of std.

@bors r=Amanieu rollup=iffy

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

📌 Commit d066dfd has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Collaborator

bors commented Oct 28, 2024

⌛ Testing commit d066dfd with merge 3f1be1e...

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 3f1be1e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2024
@bors bors merged commit 3f1be1e into rust-lang:master Oct 28, 2024
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3f1be1e): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Max RSS (memory usage)

Results (primary -1.3%, secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 782.934s -> 782.325s (-0.08%)
Artifact size: 333.69 MiB -> 333.64 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Oct 28, 2024
@RalfJung RalfJung deleted the stdarch branch October 29, 2024 18:33
@Kobzol
Copy link
Member

Kobzol commented Oct 29, 2024

One tiny regression from bumping a dependency, no need to do anything, I think.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants