-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
bump stdarch #132145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump stdarch #132145
Conversation
|
|
@bors r+ |
|
@bors rollup=iffy |
bump stdarch This lets us remove a hack from rust-lang#131349. r? `@Amanieu`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Damn, looks like we have to land #131349 first... |
|
Testing whether rust-lang/stdarch#1660 suffices to fix this. |
bump stdarch This lets us remove a hack from rust-lang#131349. r? `@Amanieu` try-job: test-various
|
Merge this into that PR, perhaps? Or does it need to happen before? |
This comment has been minimized.
This comment has been minimized.
|
Having a stdarch update together with another big change does not sound great. |
|
@bors try |
This comment was marked as outdated.
This comment was marked as outdated.
|
☀️ Try build successful - checks-actions |
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Some more @bors r=Amanieu rollup=iffy |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (3f1be1e): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.3%, secondary -1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 782.934s -> 782.325s (-0.08%) |
|
One tiny regression from bumping a dependency, no need to do anything, I think. @rustbot label: +perf-regression-triaged |
This lets us remove a hack from #131349.
r? @Amanieu
try-job: test-various