Remove support for `-Zprofile` (gcov-style coverage instrumentation) #131829

Zalathar · 2024-10-17T10:43:49Z

Tracking issue: #42524

This PR removes the unstable -Zprofile flag, which enables ”gcov-style” coverage instrumentation, along with its associated -Zprofile-emit configuration flag.

(The profile flag predates and is almost entirely separate from the stable -Cinstrument-coverage flag.)

Notably, the -Zprofile flag:

Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful.
Has no known maintainer.
Has seen no push towards stabilization.
Has at least one severe regression reported in 2022 that apparently remains unaddressed.
- Regression in code coverage (-Zprofile) at some point after nightly-2021-11-11 #100125
Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO.
Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.

rustbot · 2024-10-17T10:43:57Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-10-17T10:43:59Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Zalathar · 2024-10-17T11:29:00Z

MCP: rust-lang/compiler-team#798

Zalathar · 2024-10-30T22:17:24Z

Rebased; MCP accepted.

@rustbot ready

chenyukang · 2024-11-01T07:07:27Z

@bors r+ rollup

bors · 2024-11-01T07:07:30Z

📌 Commit ce3e14a has been approved by chenyukang

It is now in the queue for this repository.

jieyouxu · 2024-11-01T07:10:11Z

Technically this is unstable flag, but should this get compat relnotes still?

…ukang Remove support for `-Zprofile` (gcov-style coverage instrumentation) Tracking issue: rust-lang#42524 MCP: rust-lang/compiler-team#798 --- This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag. (The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.) Notably, the `-Zprofile` flag: - Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful. - Has no known maintainer. - Has seen no push towards stabilization. - Has at least one severe regression reported in 2022 that apparently remains unaddressed. - rust-lang#100125 - Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO. - Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.

Zalathar · 2024-11-01T08:28:54Z

Given the flag’s age and former importance (?), a mention in relnotes is probably warranted. I’ll try to come up with a suggested wording.

jieyouxu · 2024-11-01T08:29:44Z

@rustbot label +relnotes

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131829 (Remove support for `-Zprofile` (gcov-style coverage instrumentation)) - rust-lang#132341 (Reject raw lifetime followed by `'`, like regular lifetimes do) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments) - rust-lang#132383 (Implement suggestion for never type fallback lints) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132438 (Remove unncessary option for default rust-analyzer setting) r? `@ghost` `@rustbot` modify labels: rollup

…ukang Remove support for `-Zprofile` (gcov-style coverage instrumentation) Tracking issue: rust-lang#42524 MCP: rust-lang/compiler-team#798 --- This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag. (The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.) Notably, the `-Zprofile` flag: - Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful. - Has no known maintainer. - Has seen no push towards stabilization. - Has at least one severe regression reported in 2022 that apparently remains unaddressed. - rust-lang#100125 - Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO. - Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.

Rollup of 13 pull requests Successful merges: - rust-lang#131829 (Remove support for `-Zprofile` (gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments) - rust-lang#132383 (Implement suggestion for never type fallback lints) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132438 (Remove unncessary option for default rust-analyzer setting) - rust-lang#132439 (Add `f16` and `f128` to `invalid_nan_comparison`) - rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const) - rust-lang#132448 (Add missing backtick) - rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block) - rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable) - rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable) - rust-lang#132456 (Move remaining inline assembly test files into asm directory) - rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 14 pull requests Successful merges: - rust-lang#131829 (Remove support for `-Zprofile` (gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments) - rust-lang#132383 (Implement suggestion for never type fallback lints) - rust-lang#132413 (update offset_of! docs to reflect the stabilization of nesting) - rust-lang#132438 (Remove unncessary option for default rust-analyzer setting) - rust-lang#132439 (Add `f16` and `f128` to `invalid_nan_comparison`) - rust-lang#132444 (rustdoc: Directly use rustc_abi instead of reexports) - rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const) - rust-lang#132448 (Add missing backtick) - rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block) - rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable) - rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable) - rust-lang#132456 (Move remaining inline assembly test files into asm directory) - rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#131829 - Zalathar:goodbye-zprofile, r=chenyukang Remove support for `-Zprofile` (gcov-style coverage instrumentation) Tracking issue: rust-lang#42524 MCP: rust-lang/compiler-team#798 --- This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag. (The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.) Notably, the `-Zprofile` flag: - Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful. - Has no known maintainer. - Has seen no push towards stabilization. - Has at least one severe regression reported in 2022 that apparently remains unaddressed. - rust-lang#100125 - Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO. - Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.

It has been removed upstream in rust-lang/rust#131829

Support for -Zprofile has been removed in rust-lang/rust#131829

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

Support for -Zprofile has been removed in rust-lang/rust#131829

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

Support for -Zprofile has been removed: rust-lang/rust#131829

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

Support for -Zprofile has been removed: rust-lang/rust#131829

rustbot assigned chenyukang Oct 17, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2024

Zalathar mentioned this pull request Oct 17, 2024

Remove unstable -Zprofile (gcov-style coverage) rust-lang/compiler-team#798

Closed

3 tasks

jieyouxu added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2024

Remove support for -Zprofile (gcov-style coverage instrumentation)

ce3e14a

Zalathar force-pushed the goodbye-zprofile branch from c543244 to ce3e14a Compare October 30, 2024 22:15

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2024

matthiaskrgr mentioned this pull request Nov 1, 2024

Rollup of 6 pull requests #132446

Closed

Zalathar removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Nov 1, 2024

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 1, 2024

rustbot mentioned this pull request Nov 1, 2024

Tracking issue for release notes of #131829: Remove support for -Zprofile (gcov-style coverage instrumentation) #132447

Open

3 tasks

jieyouxu mentioned this pull request Nov 1, 2024

Rollup of 13 pull requests #132462

Closed

GuillaumeGomez mentioned this pull request Nov 1, 2024

Rollup of 14 pull requests #132470

Merged

bors merged commit 526c67f into rust-lang:master Nov 2, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 2, 2024

Zalathar deleted the goodbye-zprofile branch November 2, 2024 05:38

cakebaker added a commit to cakebaker/procps that referenced this pull request Nov 3, 2024

ci: remove -Zprofile

d4503a6

It has been removed upstream in rust-lang/rust#131829

cakebaker added a commit to cakebaker/coreutils that referenced this pull request Nov 3, 2024

ci: remove -Zprofile

326d7f6

Support for -Zprofile has been removed in rust-lang/rust#131829

This was referenced Nov 3, 2024

ci: remove -Zprofile uutils/coreutils#6842

Draft

readme: example uses -Zprofile which has been removed from Rust nightly mozilla/grcov#1240

Open

stevenengler mentioned this pull request Nov 4, 2024

Remove coverage build shadow/shadow#3433

Open

This was referenced Nov 4, 2024

Switch to lcov code coverage youki-dev/oci-spec-rs#251

Merged

Switch to lcov code coverage containers/conmon-rs#2468

Merged

cakebaker added a commit to cakebaker/procps that referenced this pull request Nov 4, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

43a9ee5

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

cakebaker added a commit to cakebaker/coreutils that referenced this pull request Nov 4, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

4993b96

Support for -Zprofile has been removed in rust-lang/rust#131829

vrbouza mentioned this pull request Nov 4, 2024

Fixing distances instead of similarity index and also query mode bug bacpop/sketchlib.rust#32

Merged

Shourya742 mentioned this pull request Nov 5, 2024

ci fix citadel-tech/coinswap#292

Merged

cakebaker added a commit to cakebaker/coreutils that referenced this pull request Nov 6, 2024

ci: use -Cprofile-generate instead of -Zprofile

615b707

Support for -Zprofile has been removed in rust-lang/rust#131829

cakebaker added a commit to cakebaker/coreutils that referenced this pull request Nov 6, 2024

ci: use -Cprofile-generate instead of -Zprofile

eccb5da

Support for -Zprofile has been removed in rust-lang/rust#131829

cakebaker added a commit to cakebaker/coreutils that referenced this pull request Nov 6, 2024

ci: use -Cprofile-generate instead of -Zprofile

a5434d8

Support for -Zprofile has been removed in rust-lang/rust#131829

jieyouxu mentioned this pull request Nov 7, 2024

Regression in code coverage (-Zprofile) at some point after nightly-2021-11-11 #100125

Closed

cakebaker added a commit to cakebaker/procps that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

8ae5e14

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

cakebaker added a commit to cakebaker/util-linux that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

45dd3a4

Support for -Zprofile has been removed: rust-lang/rust#131829

cakebaker mentioned this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile uutils/util-linux#146

Merged

sylvestre pushed a commit to cakebaker/procps that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

1420e95

Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829

cakebaker added a commit to cakebaker/findutils that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

0a88aaa

Support for -Zprofile has been removed: rust-lang/rust#131829

cakebaker mentioned this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile uutils/findutils#470

Draft

cakebaker added a commit to cakebaker/bsdutils that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

6e0ff99

Support for -Zprofile has been removed: rust-lang/rust#131829

cakebaker mentioned this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile uutils/bsdutils#70

Draft

cakebaker added a commit to cakebaker/bsdutils that referenced this pull request Nov 8, 2024

ci: use -Cinstrument-coverage instead of -Zprofile

86d03de

Support for -Zprofile has been removed: rust-lang/rust#131829

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for `-Zprofile` (gcov-style coverage instrumentation) #131829

Remove support for `-Zprofile` (gcov-style coverage instrumentation) #131829

Zalathar commented Oct 17, 2024 •

edited

Loading

rustbot commented Oct 17, 2024

rustbot commented Oct 17, 2024

Zalathar commented Oct 17, 2024

Zalathar commented Oct 30, 2024

chenyukang commented Nov 1, 2024

bors commented Nov 1, 2024

jieyouxu commented Nov 1, 2024

Zalathar commented Nov 1, 2024

jieyouxu commented Nov 1, 2024

Remove support for -Zprofile (gcov-style coverage instrumentation) #131829

Remove support for -Zprofile (gcov-style coverage instrumentation) #131829

Conversation

Zalathar commented Oct 17, 2024 • edited Loading

rustbot commented Oct 17, 2024

rustbot commented Oct 17, 2024

Zalathar commented Oct 17, 2024

Zalathar commented Oct 30, 2024

chenyukang commented Nov 1, 2024

bors commented Nov 1, 2024

jieyouxu commented Nov 1, 2024

Zalathar commented Nov 1, 2024

jieyouxu commented Nov 1, 2024

Remove support for `-Zprofile` (gcov-style coverage instrumentation) #131829

Remove support for `-Zprofile` (gcov-style coverage instrumentation) #131829

Zalathar commented Oct 17, 2024 •

edited

Loading