Add "reference" as a known compiletest header#131382
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 10, 2024
Merged
Conversation
Collaborator
|
Could not assign reviewer from: |
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
A-run-make
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
Member
|
I'll drop the legacy directive checks before this PR, it's been at least 6 months since we migrated from |
Member
|
PR dropping the legacy directive check: #131392 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 8, 2024
…heck, r=Urgau Drop compiletest legacy directive check Sufficient time has passed (> 6 months) since we migrated from `//` to `//`@`,` so let's drop the legacy directive check as it causes friction due to false positives. As a side-effect, dropping the legacy directive check simplifies the directive scanning logic. The legacy directive check was originally added to help people be aware of the migration. Blocker for rust-lang#131382 cc `@ehuss.` Can be reviewed by any compiler/bootstrap reviewer.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2024
Rollup merge of rust-lang#131392 - jieyouxu:remove-legacy-directive-check, r=Urgau Drop compiletest legacy directive check Sufficient time has passed (> 6 months) since we migrated from `//` to `//`@`,` so let's drop the legacy directive check as it causes friction due to false positives. As a side-effect, dropping the legacy directive check simplifies the directive scanning logic. The legacy directive check was originally added to help people be aware of the migration. Blocker for rust-lang#131382 cc `@ehuss.` Can be reviewed by any compiler/bootstrap reviewer.
This adds the "reference" compiletest header so that the Rust reference can add annotations to the test suite in order to link tests to individual rules in the reference. Tooling in the reference repo will be responsible for collecting these annotations and linking to the tests. More details are in MCP 783: rust-lang/compiler-team#783
ehuss
force-pushed
the
compiletest-reference
branch
from
fe33856 to
de60931
Compare
jieyouxu
approved these changes
Oct 9, 2024
Member
jieyouxu
left a comment
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks! Could you also update dev-guide about a new directive (even if it's a no-op currently).
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 9, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131382 (Add "reference" as a known compiletest header) - rust-lang#131420 (Dont ICE when encountering post-mono layout cycle error) - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`) - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`) - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now) - rust-lang#131447 (add more crash tests) - rust-lang#131456 (Fix typo in E0793) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 9, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131382 (Add "reference" as a known compiletest header) - rust-lang#131420 (Dont ICE when encountering post-mono layout cycle error) - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`) - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`) - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now) - rust-lang#131447 (add more crash tests) - rust-lang#131456 (Fix typo in E0793) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
Rollup merge of rust-lang#131382 - ehuss:compiletest-reference, r=jieyouxu Add "reference" as a known compiletest header This adds the "reference" compiletest header so that the Rust reference can add annotations to the test suite in order to link tests to individual rules in the reference. Tooling in the reference repo will be responsible for collecting these annotations and linking to the tests. More details are in MCP 783: rust-lang/compiler-team#783 There is a change from the MCP in that I am not adding the JSON collection to compiletest (at least, not yet). In looking at this more closely, that actually makes things more difficult for our tooling, so I'm leaving it out for now. If in the future it looks like something we want, then I think we can add it later. There are a few tests here which need adjusting due to the legacy header check. `@jieyouxu` indicated on Zulip that we could potentially remove the legacy header check, in which case those changes can be dropped from this PR. r? `@jieyouxu`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the "reference" compiletest header so that the Rust reference can add annotations to the test suite in order to link tests to individual rules in the reference.
Tooling in the reference repo will be responsible for collecting these annotations and linking to the tests.
More details are in MCP 783: rust-lang/compiler-team#783
There is a change from the MCP in that I am not adding the JSON collection to compiletest (at least, not yet). In looking at this more closely, that actually makes things more difficult for our tooling, so I'm leaving it out for now. If in the future it looks like something we want, then I think we can add it later.
There are a few tests here which need adjusting due to the legacy header check. @jieyouxu indicated on Zulip that we could potentially remove the legacy header check, in which case those changes can be dropped from this PR.
r? @jieyouxu