-
Notifications
You must be signed in to change notification settings - Fork 13.3k
simplify LLVM submodule handling #130918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify LLVM submodule handling #130918
Conversation
rustbot has assigned @albertlarsan68. Use |
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this change very much, tbh, as I'd like to move as much side-effect heavy and command-invocking logic as possible from Config parsing. It does not seem very intuitive that we check out a git submodule while parsing a config option. The previous code was also quite clear in that it only updated LLVM if it was already checked out, and initialized the submodule only if it wasn't downloaded in the meantime.
It seems like there is some different bug going on? The existing code should explicitly not check out LLVM if it was downloaded.
98111bd
to
a126c56
Compare
Yeah, agreed.
I'm not sure what to call it but it's not exactly a "bug". The |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
a126c56
to
cd1b245
Compare
@bors r+ |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128778 (atomics: allow atomic and non-atomic reads to race) - rust-lang#130918 (simplify LLVM submodule handling) - rust-lang#130960 (Only add an automatic SONAME for Rust dylibs) - rust-lang#130973 (compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory) - rust-lang#130976 (remove couple redundant clones) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130918 - onur-ozkan:better-llvm-submodule-handling, r=Kobzol simplify LLVM submodule handling Fixes rust-lang#130906.
Fixes #130906.