Infer nounwind and use it in MIR opts #130909

saethlin · 2024-09-26T23:47:37Z

Sinking this into layout::fn_can_unwind yields bigger MIR diffs. That's something to try tweaking.

But also, this analysis reduces incrementality because call sites depend on callee bodies. So I've currently disabled it when incremental is enabled. That's another tweak I want to try.

rustbot · 2024-09-26T23:47:41Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

saethlin · 2024-09-26T23:47:47Z

@bors try @rust-timer queue

bors · 2024-09-26T23:48:58Z

⌛ Trying commit 3f46a8e with merge f3b115d...

Infer nounwind and use it in MIR opts r? `@ghost` Sinking this into `layout::fn_can_unwind` yields bigger MIR diffs. That's something to try tweaking. But also, this analysis reduces incrementality because call sites depend on callee bodies. So I've currently disabled it when incremental is enabled. That's another tweak I want to try.

bors · 2024-09-27T01:33:27Z

☀️ Try build successful - checks-actions
Build commit: f3b115d (f3b115d087b14b64c943bbc70991eb643f40490a)

rust-timer · 2024-09-27T03:55:52Z

Finished benchmarking commit (f3b115d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.2%]	93
Regressions ❌ (secondary)	0.6%	[0.1%, 1.6%]	29
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 1.2%]	93

Max RSS (memory usage)

Results (primary -1.8%, secondary 3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 1.1%]	6
Regressions ❌ (secondary)	5.7%	[1.8%, 12.0%]	6
Improvements ✅ (primary)	-3.4%	[-8.3%, -1.2%]	9
Improvements ✅ (secondary)	-1.9%	[-3.2%, -0.7%]	2
All ❌✅ (primary)	-1.8%	[-8.3%, 1.1%]	15

Cycles

Results (primary 2.1%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.0%, 2.2%]	2
Regressions ❌ (secondary)	2.2%	[2.1%, 2.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.1%, -2.1%]	2
All ❌✅ (primary)	2.1%	[2.0%, 2.2%]	2

Binary size

Results (primary -0.1%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	2
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.2%, 0.1%]	11

Bootstrap: 774.091s -> 776.669s (0.33%)
Artifact size: 341.36 MiB -> 341.40 MiB (0.01%)

saethlin · 2024-09-27T05:43:56Z

@bors try @rust-timer queue

bors · 2024-09-27T05:45:23Z

⌛ Trying commit e0da778 with merge 7a4aba2...

Infer nounwind and use it in MIR opts r? `@ghost` Sinking this into `layout::fn_can_unwind` yields bigger MIR diffs. That's something to try tweaking. But also, this analysis reduces incrementality because call sites depend on callee bodies. So I've currently disabled it when incremental is enabled. That's another tweak I want to try.

saethlin · 2024-09-27T15:03:51Z

@rust-timer build 7a4aba2

rust-timer · 2024-09-27T16:20:53Z

Finished benchmarking commit (7a4aba2): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.8%]	57
Regressions ❌ (secondary)	0.5%	[0.2%, 1.2%]	17
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-0.7%, 0.8%]	58

Max RSS (memory usage)

Results (primary -0.3%, secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.4%, 2.7%]	10
Regressions ❌ (secondary)	3.2%	[1.8%, 5.5%]	4
Improvements ✅ (primary)	-3.8%	[-7.4%, -1.0%]	5
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-0.3%	[-7.4%, 2.7%]	15

Cycles

Results (primary 1.9%, secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.8%, 1.9%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.2%, -2.2%]	5
All ❌✅ (primary)	1.9%	[1.8%, 1.9%]	3

Binary size

Results (primary -0.1%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	2
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.2%, 0.1%]	11

Bootstrap: 774.44s -> 776.149s (0.22%)
Artifact size: 341.36 MiB -> 341.37 MiB (0.00%)

Noratrieb · 2024-09-27T20:54:06Z

compiler/rustc_mir_transform/src/lib.rs

        tcx.ensure_with_value().coroutine_by_move_body_def_id(def);
    }

+    tcx.ensure_with_value().mir_flags(def);


gotta be really sure

saethlin · 2024-09-27T21:27:14Z

@bors try @rust-timer queue

Infer nounwind and use it in MIR opts r? `@ghost` Sinking this into `layout::fn_can_unwind` yields bigger MIR diffs. That's something to try tweaking. But also, this analysis reduces incrementality because call sites depend on callee bodies. So I've currently disabled it when incremental is enabled. That's another tweak I want to try.

bors · 2024-09-27T21:28:26Z

⌛ Trying commit f0b3a5e with merge 2696107...

bors · 2024-09-27T23:14:24Z

☀️ Try build successful - checks-actions
Build commit: 2696107 (2696107c5fdecccecdcef52fca9aa9b8dfdbbcbb)

saethlin · 2024-12-09T13:39:44Z

@bors try @rust-timer queue

Infer nounwind and use it in MIR opts r? `@ghost` Sinking this into `layout::fn_can_unwind` yields bigger MIR diffs. That's something to try tweaking. But also, this analysis reduces incrementality because call sites depend on callee bodies. So I've currently disabled it when incremental is enabled. That's another tweak I want to try.

bors · 2024-12-09T13:40:56Z

⌛ Trying commit 5bf6851 with merge cc9057d...

bors · 2024-12-09T15:25:20Z

☀️ Try build successful - checks-actions
Build commit: cc9057d (cc9057d78536b9994c1cead9d34795a2c1b7279f)

rust-timer · 2024-12-09T16:42:08Z

Finished benchmarking commit (cc9057d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.4%]	3
Regressions ❌ (secondary)	1.0%	[0.3%, 5.2%]	11
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[-0.4%, 3.4%]	4

Max RSS (memory usage)

Results (primary 0.8%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[1.2%, 4.9%]	5
Regressions ❌ (secondary)	2.0%	[1.4%, 2.4%]	3
Improvements ✅ (primary)	-2.8%	[-4.1%, -1.2%]	4
Improvements ✅ (secondary)	-2.6%	[-5.8%, -1.3%]	5
All ❌✅ (primary)	0.8%	[-4.1%, 4.9%]	9

Cycles

Results (primary 3.5%, secondary 6.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.9%	[4.7%, 5.4%]	3
Regressions ❌ (secondary)	6.0%	[6.0%, 6.0%]	1
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.5%	[-1.0%, 5.4%]	4

Binary size

Results (primary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	10
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.7%, -0.0%]	11
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.7%, 0.1%]	21

Bootstrap: 767.969s -> 763.676s (-0.56%)
Artifact size: 330.85 MiB -> 330.91 MiB (0.02%)

bors · 2025-01-31T23:45:10Z

☔ The latest upstream changes (presumably #136350) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-02T16:49:57Z

☔ The latest upstream changes (presumably #136433) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-18T08:07:47Z

☔ The latest upstream changes (presumably #137162) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-04-24T01:03:57Z

☔ The latest upstream changes (presumably #138845) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-05-18T01:48:18Z

☔ The latest upstream changes (presumably #140856) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 26, 2024

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 27, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2024

Noratrieb reviewed Sep 27, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2024

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 29, 2024

saethlin added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2024

saethlin marked this pull request as draft November 6, 2024 14:03

saethlin mentioned this pull request Nov 14, 2024

Querify MonoItem collection #132566

Merged

saethlin force-pushed the infer-nounwind branch from def0a31 to e0507f3 Compare December 8, 2024 19:49

This comment has been minimized.

Sign in to view

saethlin force-pushed the infer-nounwind branch from e0507f3 to 5bf6851 Compare December 8, 2024 20:47

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 9, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 9, 2024

saethlin force-pushed the infer-nounwind branch from 5bf6851 to 9fdd6cd Compare January 27, 2025 04:15

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 31, 2025

saethlin force-pushed the infer-nounwind branch from 9fdd6cd to 614626b Compare February 1, 2025 02:08

saethlin force-pushed the infer-nounwind branch from 614626b to 38d21f8 Compare February 2, 2025 19:55

saethlin force-pushed the infer-nounwind branch from 38d21f8 to 3a4b4a7 Compare February 19, 2025 00:32

saethlin force-pushed the infer-nounwind branch from 3a4b4a7 to ce8e47f Compare March 14, 2025 18:53

Infer nounwind and use it in MIR opts

23547bc

saethlin force-pushed the infer-nounwind branch from ce8e47f to 23547bc Compare May 4, 2025 14:16

Infer nounwind and use it in MIR opts #130909

Are you sure you want to change the base?

Infer nounwind and use it in MIR opts #130909

Uh oh!

Conversation

saethlin commented Sep 26, 2024

Uh oh!

rustbot commented Sep 26, 2024

Uh oh!

saethlin commented Sep 26, 2024

Uh oh!

This comment has been minimized.

bors commented Sep 26, 2024

Uh oh!

bors commented Sep 27, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Sep 27, 2024

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

saethlin commented Sep 27, 2024

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2024

Uh oh!

saethlin commented Sep 27, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Sep 27, 2024

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

saethlin commented Sep 27, 2024

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2024

Uh oh!

bors commented Sep 27, 2024

Uh oh!

This comment has been minimized.

saethlin commented Dec 9, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 9, 2024

Uh oh!

bors commented Dec 9, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Dec 9, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

bors commented Jan 31, 2025

Uh oh!

bors commented Feb 2, 2025

Uh oh!

bors commented Feb 18, 2025

Uh oh!

bors commented Apr 24, 2025

Uh oh!

bors commented May 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants