Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #130878

Closed
wants to merge 12 commits into from

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    cac4a30 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    986e20d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f1ed9b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    5892187 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bef68c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    36455c6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129687 - Urgau:rfc3127-sysroot-2, r=jieyouxu

    Implement RFC3137 trim-paths sysroot changes - take 2
    
    This PR is a continuation of rust-lang#118149. Nothing really changed, except for rust-lang#129408 which I was able to trigger locally.
    
    Original description:
    
    > Implement parts of rust-lang#111540
    >
    > Right now, backtraces into sysroot always shows /rustc/$hash in diagnostics, e.g.
    >
    > ```
    > thread 'main' panicked at 'hello world', map-panic.rs:2:50
    > stack backtrace:
    >    0: std::panicking::begin_panic
    >              at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:616:12
    >    1: map_panic::main::{{closure}}
    >              at ./map-panic.rs:2:50
    >    2: core::option::Option<T>::map
    >              at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/option.rs:929:29
    >    3: map_panic::main
    >              at ./map-panic.rs:2:30
    >    4: core::ops::function::FnOnce::call_once
    >              at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
    > note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    > ```
    >
    > [RFC 3127 said](https://rust-lang.github.io/rfcs/3127-trim-paths.html#changing-handling-of-sysroot-path-in-rustc)
    >
    > > We want to change this behaviour such that, when rust-src source files can be discovered, the virtual path is discarded and therefore the local path will be embedded, unless there is a --remap-path-prefix that causes this local path to be remapped in the usual way.
    >
    > This PR implements this behaviour. When `rust-src` is present at compile time, rustc replaces /rustc/$hash with a real path into local rust-src with best effort. To sanitise this, users must explicitly supply `--remap-path-prefix=<path to rust-src>=foo`.
    
    cc ``@cbeuw``
    Fix rust-lang#105907
    Fix rust-lang#85463
    
    try-job: dist-x86_64-linux
    try-job: x86_64-msvc
    try-job: armhf-gnu
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    aa7aafc View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#130820 - 91khr:fix-coroutine-unit-arg, r=co…

    …mpiler-errors
    
    Fix diagnostics for coroutines with () as input.
    
    This may be a more real-life example to trigger the diagnostic:
    
    ```rust
    #![features(try_blocks, coroutine_trait, coroutines)]
    
    use std::ops::Coroutine;
    
    struct Request;
    struct Response;
    fn get_args() -> Result<String, String> { todo!() }
    fn build_request(_arg: String) -> Request { todo!() }
    fn work() -> impl Coroutine<Option<Response>, Yield = Request> {
        #[coroutine]
        |_| {
            let r: Result<(), String> = try {
                let req = get_args()?;
                yield build_request(req)
            };
            if let Err(msg) = r {
                eprintln!("Error: {msg}");
            }
        }
    }
    ```
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3bf8f9b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

    …,fee1-dead
    
    Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation
    
    Closes: rust-lang#130430
    r? rust-lang/diagnostics
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    66d10f6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35

    Utf8Chunks: add link to Utf8Chunk
    
    It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    41cf64c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#130868 - taiki-e:s390x-fixme, r=jieyouxu

    Update FIXME comment in s390x_unknown_linux_*.rs
    
    - Remove comment about "LLVM < 16" since the minimum external LLVM version is 16+ since rust-lang#117947
    - Reflect rename of cabi_s390x.rs in rust-lang@030244c (renamed to [abi/call/s390x.rs](rust-lang@030244c#diff-20136d4a18fa0ef9bd4fc2e6f92e88daad6be88bfb156e5702af39ee87ca4879), and it is currently [still in the same location](https://github.com/rust-lang/rust/blob/9e394f551c050ff03c6fc57f190e0761cf0be6e8/compiler/rustc_target/src/abi/call/s390x.rs)).
    
    r? ```@cuviper```
    
    ```@rustbot``` label +O-SystemZ
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a73b782 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#130873 - taiki-e:ppc64-atomic, r=Amanieu

    rustc_target: Add powerpc64 atomic-related features
    
    This adds the following two target features to unstable powerpc_target_feature.
    
    - `partword-atomics`: 8-bit and 16-bit atomic instructions (`l{b,h}arx` and `st{b,h}cx.`) ([definition in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L170-L172))
    - `quadword-atomics`: 128-bit atomic instructions (`lqarx` and `stqcx.`) ([definition in LLVM](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L173-L175))
    
    Both features are [available on power8+](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/PowerPC/PPC.td#L408-L422), so enabled by default for `powerpc64le-*` targets.
    
    r? `@Amanieu`
    
    `@rustbot` label +O-PowerPC
    matthiaskrgr authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a4a17a3 View commit details
    Browse the repository at this point in the history