rustdoc: do not animate :target when user prefers reduced motion #130862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
zopsicle
force-pushed
the
patch-1
branch
2 times, most recently
from
f70ea82 to
9a0c685
Compare
|
Fair enough. Can you also put the tooltip fade-out behind the flag, too? rust/src/librustdoc/html/static/css/rustdoc.css Lines 1715 to 1721 in 9e394f5 |
This accessibility improvement gates the target flashing and tooltip fade-out behind an inverted prefers-reduced-motion media query.
|
Done, thanks for bringing it up. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Still a comment of mine remaining. I'd prefer for it to be done before merging if you don't mind. @bors r- |
bors
added
S-waiting-on-author
GuillaumeGomez
approved these changes
Sep 26, 2024
|
Thanks! @bors r=notriddle,GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#130279 (Document subtleties of `ManuallyDrop`) - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config) - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations) - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`) - rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code) - rust-lang#130880 (add missing FIXME(const-hack)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
Rollup merge of rust-lang#130862 - zopsicle:patch-1, r=notriddle,GuillaumeGomez rustdoc: do not animate :target when user prefers reduced motion This accessibility improvement gates rust-lang#129284 behind an inverted [prefers-reduced-motion](https://developer.mozilla.org/en-US/docs/Web/CSS/`@media/prefers-reduced-motion)` media query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accessibility improvement gates #129284 behind an inverted prefers-reduced-motion media query.