-
Notifications
You must be signed in to change notification settings - Fork 13.3k
move enzyme flags from general cargo to rustc-specific cargo #130648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
I can confirm that cherry-picking this pr (and a minor fix due to being 2 weeks behind) worked for the full rustc-ad fork, I could run all of our (not yet upstreamed) tests: https://github.com/rust-lang/rust/pull/130648/files, so it would be great if this gets approved, since it will enable running enzyme in the compiler explorer. |
@bors r+ |
We don't (currently) build Enzyme/autodiff by default, so I think this could just be rollup=allways, since it won't affect the CI builds. |
move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
We usually rollup PRs unless they are explicitly tagged with rollup=never/iffy. |
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#130648 (move enzyme flags from general cargo to rustc-specific cargo) - rust-lang#130650 (Fixup Apple target's description strings) - rust-lang#130664 (Generate line numbers for non-rust code examples as well) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130669 (tests: Test that `extern "C" fn` ptrs lint on slices) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130648 - onur-ozkan:enzyme-linking, r=Kobzol move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
@onur-ozkan this was a good improvement, but I think it still needs to become a bit more precise, see e.g. the cranelift build failure: https://github.com/rust-lang-ci/rust/actions/runs/14826601681/job/41620576833 What would be the best way to solve this? Is cranelift trying to bootstrap itself here without LLVM and hence Enzyme? At least it looks suspicious that exactly the one project not needing llvm fails. At least locally I have Enzyme in a few locations, so generally it shouldn't be too hard to specify a suitable link even in /rustlib, where cranelift mostly seems to live. The strange thing is that I can't find a code path in the source code which would end with us adding
|
I don't have enough time to dive into this context these days.
The version part is handled programmatically; it's not hardcoded. You can search for |
Resolves #130637.
Tracking: