Fix lint levels not getting overridden by attrs on Stmt nodes#130293
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 15, 2024
Merged
Fix lint levels not getting overridden by attrs on Stmt nodes#130293bors merged 1 commit intorust-lang:masterfrom
Stmt nodes#130293bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
@cjgillot Looks like just visiting the |
rustbot
added
S-waiting-on-review
Contributor
|
Do you mind rebasing on master? #130050 should have fixed that issue. |
gurry
force-pushed
the
130142-lint-level-issue
branch
from
bea0e64 to
51b3b20
Compare
This comment has been minimized.
This comment has been minimized.
gurry
force-pushed
the
130142-lint-level-issue
branch
from
51b3b20 to
fd3ee92
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Contributor
Author
Rebasing worked. Thanks :). Please review |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129439 (Implement feature `string_from_utf8_lossy_owned` for lossy conversion from `Vec<u8>` to `String` methods) - rust-lang#129828 (miri: treat non-memory local variables properly for data race detection) - rust-lang#130110 (make dist vendoring configurable) - rust-lang#130293 (Fix lint levels not getting overridden by attrs on `Stmt` nodes) - rust-lang#130342 (interpret, miri: fix dealing with overflow during slice indexing and allocation) Failed merges: - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
Rollup merge of rust-lang#130293 - gurry:130142-lint-level-issue, r=cjgillot Fix lint levels not getting overridden by attrs on `Stmt` nodes Fixes rust-lang#130142. See comments on the issue for context. r? `@cjgillot`
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…jgillot Fix lint levels not getting overridden by attrs on `Stmt` nodes Fixes rust-lang#130142. See comments on the issue for context. r? `@cjgillot`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130142. See comments on the issue for context.
r? @cjgillot