Use a small runner for msvc-ext2 job#130151
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 16, 2024
Merged
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-testsuite
Member
Author
|
@bors try |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2024
Use a small runner for msvc-ext2 job Hopefully this should eliminate the errors from this job. The only question is how long it takes. try-job: x86_64-msvc-ext2
Collaborator
|
☀️ Try build successful - checks-actions |
Member
Author
|
2h 25m 34s on that run. That seems roughly in line with the other long running job. I guess it's reviewers choice on if this is ok. According to @ehuss's tests, I think this should eliminate the error on this runner. And since the errors on other runners are now much less frequent, it should be a noticeable improvement to CI success rates. |
Member
|
r=me if we still need this |
Member
Author
|
Looks like this is still needed @bors r=Mark-Simulacrum |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#130151 (Use a small runner for msvc-ext2 job) - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory) - rust-lang#130409 (tests: more ice tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2024
Rollup merge of rust-lang#130151 - ChrisDenton:slow-ci, r=Mark-Simulacrum Use a small runner for msvc-ext2 job Hopefully this should eliminate the errors from this job. The only question is how long it takes. try-job: x86_64-msvc-ext2
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2024
…try> Revert MSVC CI changes - rust-lang#130151 - rust-lang#130072 try-job: x86_64-msvc try-job: x86_64-msvc-ext
Merged
cuviper
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
[beta] backports - Only add an automatic SONAME for Rust dylibs rust-lang#130960 - Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055 - Disable jump threading `UnOp::Not` for non-bool rust-lang#131201 - Update LLVM submodule rust-lang#131448 - Split x86_64-msvc-ext into two jobs rust-lang#130072 - Use a small runner for msvc-ext2 job rust-lang#130151 r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2024
[experiment] Try reverting the MSVC workarounds Get a fresh set of runs with the following workarounds reverted: - rust-lang#130151 - rust-lang#130072 - rust-lang#133248 try-job: x86_64-msvc try-job: x86_64-msvc-ext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this should eliminate the errors from this job. The only question is how long it takes.
try-job: x86_64-msvc-ext2