Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #129985

Closed
wants to merge 38 commits into from

Commits on Aug 26, 2024

  1. Add a run-make test for checking that certain rustc_ crates build o…

    …n stable
    Kobzol authored and lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    893413d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7957140 View commit details
    Browse the repository at this point in the history
  3. run test in tmp dir and emit artifacts there

    otherwise the test would build in the source root's `target` folder
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d9794a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2190c28 View commit details
    Browse the repository at this point in the history
  5. separate the crates to test from the test setup

    it'll be easier to see and update the list: the other cmd args
    can just be ignored
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0577035 View commit details
    Browse the repository at this point in the history
  6. remove unneeded type ascription

    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f1df0c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Remove the 'body lifetime on FilterInformation.

    It's not needed.
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c6111c0 View commit details
    Browse the repository at this point in the history
  2. Move WriteInfo out of Allocations.

    It doesn't need to be in there, and the move simplifies lifetimes.
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0a282ea View commit details
    Browse the repository at this point in the history
  3. Remove Allocations.

    It's not necessary, and just complicates things.
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ad5a6e1 View commit details
    Browse the repository at this point in the history
  4. Simplify Candidate.

    By making it own the index maps, instead of holding references to them.
    This requires moving the free function `find_candidate` into
    `Candidate::reset_and_find`. It lets the `'alloc` lifetime be removed
    everywhere that still has it.
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1be2204 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    0d156f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b75f8a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    5afc461 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84259ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    35a7c1b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd5f7bc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4825fb1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a85632 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    01d8235 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. address review comments

    lqd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a178559 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3af6dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55bc638 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Pin memchr to 2.5.0 in the library rather than rustc_ast

    The latest versions of `memchr` experience LTO-related issues when
    compiling for windows-gnu [1], so needs to be pinned. The issue is
    present in the standard library.
    
    `memchr` has been pinned in `rustc_ast`, but since the workspace was
    recently split, this pin no longer has any effect on library crates.
    
    Resolve this by adding `memchr` as an _unused_ dependency in `std`,
    pinned to 2.5. Additionally, remove the pin in `rustc_ast` to allow
    non-library crates to upgrade to the latest version.
    
    Link: rust-lang#127890 [1]
    tgross35 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8f0ea94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c671a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07c0585 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    65e78db View commit details
    Browse the repository at this point in the history
  5. Update marker.rs

    chancancode authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3626b66 View commit details
    Browse the repository at this point in the history
  6. Update marker.rs

    chancancode authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    efc20de View commit details
    Browse the repository at this point in the history
  7. Update marker.rs

    chancancode authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    277a08c View commit details
    Browse the repository at this point in the history
  8. Update marker.rs

    chancancode authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e45b53e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7157f98 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Do not request sanitizers for naked functions

    Naked functions can only contain inline asm, so any instrumentation
    inserted by sanitizers is illegal. Don't request it.
    
    Fixes rust-lang#129224.
    nikic committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1c8f5db View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol

    Add test to build crates used by r-a on stable
    
    r? `@Kobzol`
    
    I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c3253ac View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#129624 - tgross35:cargo-update, r=Mark-Simu…

    …lacrum
    
    Adjust `memchr` pinning and run `cargo update`
    
    try-job: x86_64-mingw
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fe5e59a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#129720 - nnethercote:simplify-dest_prop-mm,…

    … r=cjgillot
    
    Simplify DestProp memory management
    
    The DestProp MIR pass has some convoluted memory management. This PR simplifies it.
    
    r? `@davidtwco`
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    efdbbee View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129796 - GuillaumeGomez:unify-code-examples…

    …, r=notriddle
    
    Unify scraped examples with other code examples
    
    Fixes rust-lang#129763.
    
    This first PR both fixes rust-lang#129763 but also unifies buttons display for code examples:
    
    ![image](https://github.com/user-attachments/assets/c8475945-dcc3-4c25-8d7d-1659f85301c8)
    
    You can test it [here](https://rustdoc.crud.net/imperio/unify-code-examples/doc/scrape_examples/fn.test.html) and [here](https://rustdoc.crud.net/imperio/unify-code-examples/doc/scrape_examples/fn.test_many.html).
    
    I'm planning to send a follow-up to make the buttons generated in JS directly (or I can do it in this PR directly if you prefer).
    
    cc `@willcrichton`
    r? `@notriddle`
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a6fe092 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#129891 - nikic:naked-no-san, r=jackh726

    Do not request sanitizers for naked functions
    
    Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.
    
    Fixes rust-lang#129224.
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c6fb9d3 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#129938 - chancancode:patch-1, r=thomcc

    Elaborate on deriving vs implementing `Copy`
    
    I was reading this documentation and this wasn't immediately clear to me.
    
    In my mind, it seemed obvious that a type can only claim to be `Copy` if the bits it is storing can be `Copy`, and in the case of a generic struct that can only be the case if `T: Copy`. So the bound added by the derive seemed necessary at all times, and I thought what the documentation was trying to say is that the custom implementation allows you to add _additional bounds_.
    
    Of course what it was actually trying to point out is that just because you have a generic parameter `T`, it doesn't necessarily mean you are storing the bits of `T`. And if you aren't, it may be the case that your own bits can be copied regardless of whether the bits of `T` can be safely copied.
    
    Thought it may be worth elaborating to make that a bit more clear. Haven't tested/didn't try to figure out how to render this locally. Mainly not sure if the `PhantomData` back link is going to just work or need some extra stuff, but I figured someone else probably could just tell.
    matthiaskrgr authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e835f22 View commit details
    Browse the repository at this point in the history