Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joboet and others added 20 commits August 1, 2024 14:41
The main new feature is support for detecting the current stack size on
illumos. (See my blog post [1] for the context which led to this.)

[1]: https://sunshowers.io/posts/rustc-segfault-illumos/
core: use `compare_bytes` for more slice element types

`bool`, `NonZero<u8>`, `Option<NonZero<u8>>` and `ascii::Char` can be compared the same way as `u8`.
…esses-in-parser, r=scottmcm

refactor: standardize duplicate processes in parser

## Summary
This PR refactors the `read_number` function to standardize duplicate code, improve readability, and enhance efficiency.

## Changes
- Merged the logic for both `max_digits` cases into a single `read_atomically` closure
- Simplified control flow and reduced code duplication
…gillot

Lint that warns when an elided lifetime ends up being a named lifetime

As suggested in rust-lang#48686 (comment)

Fixes rust-lang#48686
…chenkov

Create opaque definitions in resolver.

Implementing rust-lang#129023 (comment)

That was easier than I expected.

r? `@petrochenkov`
…Simulacrum

Update stacker to 0.1.17

The main new feature is support for detecting the current stack size on illumos. (See [my blog post] for the context which led to this.)

[my blog post]: https://sunshowers.io/posts/rustc-segfault-illumos/

try-job: x86_64-mingw
…ark-Simulacrum

Make option-like-enum.rs UB-free and portable

Fixes rust-lang#129662

(or, at least the parts of it that aren't rust-lang#128973)
add crashtests for several old unfixed ICEs

Adds several new crashtests for some older ICEs that did not yet have any.
Tests were added for rust-lang#128097, rust-lang#119095, rust-lang#117460 and rust-lang#126443.
Remove stray dot in `std::char::from_u32_unchecked` documentation
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 1, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Collaborator

bors commented Sep 1, 2024

📌 Commit 2261ffa has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2024
@bors
Copy link
Collaborator

bors commented Sep 1, 2024

⌛ Testing commit 2261ffa with merge 78d5c04...

@bors
Copy link
Collaborator

bors commented Sep 1, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 78d5c04 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2024
@bors bors merged commit 78d5c04 into rust-lang:master Sep 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 1, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#128495 core: use compare_bytes for more slice element types 5cf3e06c97f11b3ad7609d7569ed4f675f4c0bdf (link)
#128641 refactor: standardize duplicate processes in parser 3cb154ab0cd832904dc6958ab7a2a443ff48bc2d (link)
#129207 Lint that warns when an elided lifetime ends up being a nam… e7413a9604817f308db5d1164babc8cb9882d2ec (link)
#129493 Create opaque definitions in resolver. c8f66247068f30b11d9754f8a391c24596c8c705 (link)
#129619 Update stacker to 0.1.17 eceab25a9b86c6d12293dab69e1e7636bbe8424a (link)
#129672 Make option-like-enum.rs UB-free and portable 09adf747f15d6507da5956e155ac119d4f1c20a2 (link)
#129780 add crashtests for several old unfixed ICEs 1aed196bcf16379d18485b99860d9531f48e7242 (link)
#129832 Remove stray dot in std::char::from_u32_unchecked documen… 45df2dbca0af76b10eee5a0a7362367165596ff1 (link)

previous master: 43eaa5c624

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (78d5c04): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [0.4%, 3.1%] 3
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Max RSS (memory usage)

Results (primary -0.2%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.4%, 9.3%] 32
Regressions ❌
(secondary)
0.9% [0.4%, 2.6%] 51
Improvements ✅
(primary)
-1.0% [-5.2%, -0.4%] 50
Improvements ✅
(secondary)
-0.9% [-2.7%, -0.4%] 24
All ❌✅ (primary) -0.2% [-5.2%, 9.3%] 82

Cycles

Results (primary -0.2%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.5% [0.4%, 2.8%] 10
Regressions ❌
(secondary)
1.4% [0.4%, 6.4%] 48
Improvements ✅
(primary)
-0.7% [-3.3%, -0.4%] 35
Improvements ✅
(secondary)
-0.8% [-3.2%, -0.4%] 79
All ❌✅ (primary) -0.2% [-3.3%, 2.8%] 45

Binary size

Results (primary -0.6%, secondary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
0.4% [0.4%, 0.5%] 4
Improvements ✅
(primary)
-0.6% [-1.6%, -0.1%] 29
Improvements ✅
(secondary)
-1.0% [-1.4%, -0.8%] 9
All ❌✅ (primary) -0.6% [-1.6%, 1.0%] 30

Bootstrap: 789.934s -> 789.43s (-0.06%)
Artifact size: 338.74 MiB -> 338.46 MiB (-0.08%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.