Add `unreachable_pub`, round 4 #129777

nnethercote · 2024-08-30T07:02:17Z

A follow-up to #129732.

r? @Urgau

rustbot · 2024-08-30T07:02:27Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Urgau · 2024-08-30T08:40:37Z

@bors r+

bors · 2024-08-30T08:40:39Z

📌 Commit 772207e has been approved by Urgau

It is now in the queue for this repository.

…rgau Add `unreachable_pub`, round 4 A follow-up to rust-lang#129732. r? `@Urgau`

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#129630 (Document the broken C ABI of `wasm32-unknown-unknown`) - rust-lang#129711 (Expand NLL MIR dumps) - rust-lang#129730 (f32 docs: define 'arithmetic' operations) - rust-lang#129733 (Subtree update of `rust-analyzer`) - rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection) - rust-lang#129760 (Make the "detect-old-time" UI test more representative) - rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4) - rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt) - rust-lang#129785 (Miri subtree update) - rust-lang#129791 (mark joboet as on vacation) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#129659 (const fn stability checking: also check declared language features) - rust-lang#129711 (Expand NLL MIR dumps) - rust-lang#129730 (f32 docs: define 'arithmetic' operations) - rust-lang#129733 (Subtree update of `rust-analyzer`) - rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection) - rust-lang#129760 (Make the "detect-old-time" UI test more representative) - rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4) - rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt) - rust-lang#129785 (Miri subtree update) - rust-lang#129791 (mark joboet as on vacation) - rust-lang#129812 (interpret, codegen: tweak some comments and checks regarding Box with custom allocator) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) r? `@ghost` `@rustbot` modify labels: rollup

…rgau Add `unreachable_pub`, round 4 A follow-up to rust-lang#129732. r? ````@Urgau````

bors · 2024-08-31T20:09:48Z

☔ The latest upstream changes (presumably #129817) made this pull request unmergeable. Please resolve the merge conflicts.

nnethercote · 2024-09-01T23:09:04Z

I rebased.

@bors r=Urgau rollup

bors · 2024-09-01T23:09:07Z

📌 Commit 010666f has been approved by Urgau

It is now in the queue for this repository.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#129152 (custom/external clippy support for bootstrapping) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129829 (Make decoding non-optional `LazyArray` panic if not set) - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`) - rust-lang#129875 (chore: Fix typos in 'compiler' (batch 1)) - rust-lang#129877 (chore: Fix typos in 'compiler' (batch 2)) - rust-lang#129878 (chore: Fix typos in 'compiler' (batch 3)) - rust-lang#129891 (Do not request sanitizers for naked functions) - rust-lang#129892 (Clarify language around ptrs in slice::raw) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

nnethercote · 2024-09-03T00:12:25Z

I rebased.

@bors r=Urgau

bors · 2024-09-03T00:12:27Z

📌 Commit 88b6a78 has been approved by Urgau

It is now in the queue for this repository.

saethlin · 2024-09-03T01:02:06Z

@matthiaskrgr has pushed a conflicting rollup ahead of this PR twice already, and has two more rollups in queue right now. So I think it's likely he's just going to keep producing merge conflicts for this PR, which is creating more work for others out of thin air.

@bors rollup=never p=50

bors · 2024-09-03T01:27:24Z

⌛ Testing commit 88b6a78 with merge 6199b69...

bors · 2024-09-03T03:49:47Z

☀️ Test successful - checks-actions
Approved by: Urgau
Pushing 6199b69 to master...

rust-timer · 2024-09-03T05:05:36Z

Finished benchmarking commit (6199b69): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 749.903s -> 749.154s (-0.10%)
Artifact size: 338.37 MiB -> 338.32 MiB (-0.02%)

rustbot assigned Urgau Aug 30, 2024

Urgau approved these changes Aug 30, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 31, 2024

Rollup merge of rust-lang#129777 - nnethercote:unreachable_pub-4, r=U…

9292173

…rgau Add `unreachable_pub`, round 4 A follow-up to rust-lang#129732. r? `@Urgau`

workingjubilee mentioned this pull request Aug 31, 2024

Rollup of 6 pull requests #129803

Closed

matthiaskrgr mentioned this pull request Aug 31, 2024

Rollup of 11 pull requests #129810

Closed

matthiaskrgr mentioned this pull request Aug 31, 2024

Rollup of 12 pull requests #129817

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024

Rollup merge of rust-lang#129777 - nnethercote:unreachable_pub-4, r=U…

66366f5

…rgau Add `unreachable_pub`, round 4 A follow-up to rust-lang#129732. r? ````@Urgau````

matthiaskrgr mentioned this pull request Aug 31, 2024

Rollup of 12 pull requests #129830

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2024

nnethercote force-pushed the unreachable_pub-4 branch from 772207e to 010666f Compare September 1, 2024 22:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2024

matthiaskrgr mentioned this pull request Sep 2, 2024

Rollup of 9 pull requests #129873

Merged

nnethercote added 13 commits September 3, 2024 08:49

Add warn(unreachable_pub) to rustc_sanitizers.

19843bb

Add warn(unreachable_pub) to rustc_serialize.

21a37da

Add warn(unreachable_pub) to rustc_session.

19ff6e6

Add warn(unreachable_pub) to rustc_smir.

b457ab3

Add warn(unreachable_pub) to rustc_span.

b0f22ff

Add warn(unreachable_pub) to rustc_symbol_mangling.

89deb3c

Add warn(unreachable_pub) to rustc_target.

0fb3a50

Add warn(unreachable_pub) to rustc_traits.

c4f6f52

Add warn(unreachable_pub) to rustc_trait_selection.

2e358e6

Add warn(unreachable_pub) to rustc_transmute.

e4b1e28

Add warn(unreachable_pub) to rustc_type_ir.

3e09c45

Add warn(unreachable_pub) to rustc_ty_utils.

d7caea1

Add warn(unreachable_pub) to rustc_const_eval.

88b6a78

nnethercote force-pushed the unreachable_pub-4 branch from 010666f to 88b6a78 Compare September 3, 2024 00:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2024

bors merged commit 6199b69 into rust-lang:master Sep 3, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 3, 2024

This was referenced Sep 3, 2024

Remove -Zfuel. #115293

Open

Stabilize &mut (and *mut) as well as &Cell (and *const Cell) in const #129195

Merged

Apple: Refactor deployment target version parsing #129341

Merged

nnethercote deleted the unreachable_pub-4 branch September 3, 2024 06:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `unreachable_pub`, round 4 #129777

Add `unreachable_pub`, round 4 #129777

nnethercote commented Aug 30, 2024

rustbot commented Aug 30, 2024

Urgau commented Aug 30, 2024

bors commented Aug 30, 2024

bors commented Aug 31, 2024

nnethercote commented Sep 1, 2024

bors commented Sep 1, 2024

nnethercote commented Sep 3, 2024

bors commented Sep 3, 2024

saethlin commented Sep 3, 2024 •

edited

Loading

bors commented Sep 3, 2024

bors commented Sep 3, 2024

rust-timer commented Sep 3, 2024

Add unreachable_pub, round 4 #129777

Add unreachable_pub, round 4 #129777

Conversation

nnethercote commented Aug 30, 2024

rustbot commented Aug 30, 2024

Urgau commented Aug 30, 2024

bors commented Aug 30, 2024

bors commented Aug 31, 2024

nnethercote commented Sep 1, 2024

bors commented Sep 1, 2024

nnethercote commented Sep 3, 2024

bors commented Sep 3, 2024

saethlin commented Sep 3, 2024 • edited Loading

bors commented Sep 3, 2024

bors commented Sep 3, 2024

rust-timer commented Sep 3, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Add `unreachable_pub`, round 4 #129777

Add `unreachable_pub`, round 4 #129777

saethlin commented Sep 3, 2024 •

edited

Loading