Prereq2 for async drop - ResumedAfterDrop panic messages #129736
Draft
+351
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This was referenced Aug 29, 2024
Draft
azhogin
force-pushed
the
azhogin/async-drop-prereq2-resumed-after-drop-msg
branch
from
aca1a66
to
286f4c0
Compare
azhogin
force-pushed
the
azhogin/async-drop-prereq2-resumed-after-drop-msg
branch
from
286f4c0
to
99b7c82
Compare
azhogin
force-pushed
the
azhogin/async-drop-prereq2-resumed-after-drop-msg
branch
from
99b7c82
to
edaf9ce
Compare
|
☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 2 PR of #123948, just for review purposes.
ResumedAfterDrop messages for panic when coroutine is resumed after it is started to be async drop'ed.
Review only last commit, based on previous PR #129734