Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: allow stmt/expr macro invocations to be delimited by []. #12947

Conversation

glaebhoerl
Copy link
Contributor

this is useful for macros like vec! which construct containers

This is a followup to @huonw's earlier change which allowed {} to be used as delimiters. I'm acting at the behest of @eddyb on IRC, who also wanted vec![a, b, c]. Is this the sort of change which now requires going through the RFC process?

this is useful for macros like vec! which construct containers
@huonw
Copy link
Member

huonw commented Mar 17, 2014

I think this would be neat.

@huonw
Copy link
Member

huonw commented Mar 25, 2014

Yes, theoretically this should go via the RFC process but an exception was made, and this was accepted in the meeting: https://github.com/mozilla/rust/wiki/Meeting-weekly-2014-03-25#-on-macros

(Needs a rebase.)

@sfackler
Copy link
Member

bump

bors added a commit that referenced this pull request Apr 1, 2014
this is useful for macros like vec! which construct containers

rebase of #12947 because I'm impatient.
@seanmonstar
Copy link
Contributor

should be closed, was merged in other PR

@thestinger thestinger closed this Apr 1, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 9, 2022
Don't switch workspace on vfs file changes from libraries

When r-a starts up, it starts switching the workspace before all vfs
events have been processed which causes us to switch workspace multiple
times until all vfs changes have been processed. This scales with the
size of the project and its dependencies. If workspace files from
dependencies as well as the sysroot get loaded, we shouldn't switch
the workspace as those have no impact on the project workspace.
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 23, 2022
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 23, 2022
Revert rust-lang#12947, trigger workspace switches on all structure changes again

Closes rust-lang/rust-analyzer#13029
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 27, 2024
…xFrednet

Pause assignments to @xFrednet for summer break 🏖️

I'm only removing myself from the assignment roulette as I want to allow `r? xFrednet` for `gh-pages` and other updates. So feel free to still `r?` me.

r? `@ghost`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants