Delete debuginfo test suite infra for gdb without Rust support and lldb with Rust support #129218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
gdb-supports-rust-now
branch
from
6f64cb0 to
3126289
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
gdb-supports-rust-now
branch
from
2faf713 to
68bb911
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
gdb-supports-rust-now
branch
from
68bb911 to
259bb30
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2024
Delete debuginfo test suite support for gdb/lldb without native Rust support Implements rust-lang#128953 I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken. r? `@ghost` try-job: aarch64-apple try-job: aarch64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: i686-gnu try-job: i686-gnu-nopt try-job: i686-mingw try-job: i686-msvc try-job: test-various try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #128982) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
gdb-supports-rust-now
branch
from
259bb30 to
355bf05
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2024
Delete debuginfo test suite support for gdb/lldb without native Rust support Implements rust-lang#128953 I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken. Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version. This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately. try-job: x86_64-apple-1
|
💔 Test failed - checks-actions |
saethlin
force-pushed
the
gdb-supports-rust-now
branch
from
14f0e8f to
b2dae98
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2024
Delete debuginfo test suite support for gdb/lldb without native Rust support Implements rust-lang#128953 I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken. Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version. This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately. try-job: x86_64-apple-1 try-job: aarch64-apple
saethlin
changed the title
saethlin
changed the title
4 tasks
|
☀️ Try build successful - checks-actions |
saethlin
added
S-waiting-on-review
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
jieyouxu
approved these changes
Aug 19, 2024
src/tools/compiletest/src/runtest.rs
Outdated
| println!("NOTE: compiletest thinks it is using GDB without native rust support"); | ||
| PREFIXES | ||
| }; | ||
| let prefixes = &["gdb"]; |
|
|
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (4fe1e2b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 749.421s -> 749.361s (-0.01%) |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 26, 2025
tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) directives and `gdbg-check` (for plain `gdb`) directives were added. But in two places the author accidentally wrote `gdbt-check` instead (`t` is next to `r` on the keyboard). This commit fixes that typo. rust-lang#129218 later renamed `gdbr-check` to just `gdb-check` which is why we rename to `gdb-check` directly. The test still passes locally for me after the change, but fails if I change the `gdb-check` checks to check for some other string, so the check seems to still perform its intended function. Note that we need to add a `std::hint::black_box()` to avoid $4 = <optimized out> prints on at least `aarch64-gnu-llvm-20-1`. After this there are no more instances of the string `gdbt` in the code base: ```console $ git grep gdbt ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #128953
I also deleted all the
min-lldb-version: 310comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version.
This PR is multiple highly mechanical changes. Some of the commits were created by just running
sed. You may find it easier to review each commit separately.