Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize std::path::Path::file_prefix #129114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mbhall88
Copy link
Contributor

This PR proposes to stabilize std::path::Path::file_prefix.

I believe the first step is actually starting an FCP, but it was mentioned that the easiest way to achieve this was to open this stabilization PR first.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@mbhall88
Copy link
Contributor Author

@rustbot modify labels: +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 15, 2024
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@mbhall88 mbhall88 changed the title stabilize std::path::file_prefix stabilize std::path::Path::file_prefix Aug 15, 2024
library/std/src/path.rs Outdated Show resolved Hide resolved
Co-authored-by: Slanterns <slanterns.w@gmail.com>
@slanterns
Copy link
Contributor

You should ask T-libs-api for FCP and merge, not me :)

@jieyouxu jieyouxu added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Aug 22, 2024
@tgross35
Copy link
Contributor

Note that I suggested creating this PR as a way to get it on the radar, but I am of the opinion that the iterator API proposed at #86319 (comment) may be a preferable alternative. They are not mutually exclusive, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants