Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #128829

Closed
wants to merge 14 commits into from

Commits on Jul 28, 2024

  1. Update NonNull::align_offset quarantees

    Update NonNull::align_offset quarantees, keeping it in sync with ptr::align_offset
    WiktorPrzetacznik authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    3d7aa16 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Configuration menu
    Copy the full SHA
    470ada2 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Add test

    tiif committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8eaef3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c14c3d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    7869400 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c29e0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9289f56 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#128306 - WiktorPrzetacznik:WiktorPrzetaczni…

    …k-nonnull-alignoffset-update, r=Amanieu
    
    Update NonNull::align_offset quarantees
    
    This PR proposes to update [`NonNull::align_offset`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.align_offset) guarantees, which should to be matched with [`ptr::align_offset`](https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.align_offset-1)
    (as `NonNull::align_offset` delegates to `ptr::align_offset`).
    
    [PR rust-lang#121201](rust-lang#121201) updated only `ptr::align_offset` docs.
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c691467 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#128612 - compiler-errors:validate-mir-opt-m…

    …ir, r=davidtwco
    
    Make `validate_mir` ensure the final MIR for all bodies
    
    A lot of the crashes tests use `-Zpolymorphize` or `-Zdump-mir` for their side effect of computing the `optimized_mir` for all bodies, which will uncover bugs with late MIR passes like the inliner. I don't like having all these tests depend on `-Zpolymorphize` (or other hacky ways) for no reason, so this PR extends the `-Zvalidate-mir` flag to ensure `optimized_mir`/`mir_for_ctfe` for all body owners during the analysis phase.
    
    Two thoughts:
    1. This could be moved later in the compilation pipeline I guess? I don't really think it matters, though.
    1. This could alternatively be expressed using a new flag, though I don't necessarily see much value in separating these.
    
    For example, rust-lang#128171 could have used this flag, in the `tests/ui/polymorphization/inline-incorrect-early-bound.rs`.
    
    r? mir
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    447d461 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee26ae8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128791 - compiler-errors:async-fn-unsafe, r…

    …=lcnr
    
    Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`
    
    Due to unsafety, ABI, or the presence of target features, some `FnDef`/`FnPtr` types don't implement `Fn*`. Do the same for `AsyncFn*`.
    
    Noticed this due to rust-lang#128764, but this isn't really related to that ICE, which is fixed in rust-lang#128792.
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1d6077d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#128795 - zachs18:e0517-update-for-rfc-2195,…

    … r=jieyouxu
    
    Update E0517 message to reflect RFC 2195.
    
    E0517 occurs when a `#[repr(..)]` attribute is placed on an unsupported item. Currently, the explanation of the error implies that `#[repr(u*/i*)]` cannot be placed on fieldful enums, which is no longer the case since [RFC 2195](rust-lang/rfcs#2195) was [stabilized](rust-lang#60553), which allows placing `#[repr(u*/i*)]` and/or `#[repr(C)]` on fieldful enums to produce a defined layout.
    
    This PR doesn't (currently) add a description of the semantics of placing `#[repr(u*/i*)]` on a fieldful enum to the error explanation, it just removes the claims/implications that it is not allowed.
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    43cdef7 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#128825 - bvanjoi:useless-resolver-field, r=…

    …petrochenkov
    
    rm `declared_features` field in resolver
    
    r? `@petrochenkov`
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    40a79e7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#128826 - Alexendoo:lint-override-suggestion…

    …s, r=compiler-errors
    
    Only suggest `#[allow]` for `--warn` and `--deny` lint level flags
    
    `--force-warn` and `--forbid` cannot be overridden
    matthiaskrgr authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f92c323 View commit details
    Browse the repository at this point in the history