Rollup of 3 pull requests #128774
Closed
Rollup of 3 pull requests #128774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, r=jieyouxu Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The `long-linker` tests are certainly doing something... interesting - they summon `rustc` calls with obscene quantities of arguments and check that this is appropriately handled. I removed the `RUSTC_ORIGINAL` magic - it's equivalent to `RUSTC` in `tools.mk`, so what is the purpose? Making it so the massive pile of flags doesn't modify rustc itself and start leaking into other tests? Tell me what you think. Please try: try-job: x86_64-msvc try-job: i686-msvc try-job: x86_64-mingw try-job: i686-mingw try-job: aarch64-apple try-job: test-various try-job: x86_64-gnu-debug try-job: x86_64-gnu-llvm-17
…jieyouxu Migrate `min-global-align` and `no-alloc-shim` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: x86_64-gnu-llvm-17
…-m, r=jieyouxu migrate `thumb-none-cortex-m` to rmake tracking issue: rust-lang#121876 I'll leave some comments/questions inline r? `@jieyouxu` try-job: armhf-gnu try-job: dist-various-1 try-job: test-various
rustbot
added
A-run-make
|
(didn't mean to comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
cross-lang-lto-upstream-rlibs,long-linker-command-linesandlong-linker-command-lines-cmd-exerun-maketests to rmake #128196 (Migratecross-lang-lto-upstream-rlibs,long-linker-command-linesandlong-linker-command-lines-cmd-exerun-maketests to rmake)min-global-alignandno-alloc-shimrun-maketests to rmake #128407 (Migratemin-global-alignandno-alloc-shimrun-maketests to rmake)thumb-none-cortex-mto rmake #128636 (migratethumb-none-cortex-mto rmake)Failed merges:
thumb-none-qemuto rmake #128639 (migratethumb-none-qemuto rmake)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup