derive(SmartPointer): Add changes that were not rolled up in #127681#128451
Closed
compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Closed
derive(SmartPointer): Add changes that were not rolled up in #127681#128451compiler-errors wants to merge 1 commit intorust-lang:masterfrom
derive(SmartPointer): Add changes that were not rolled up in #127681#128451compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
Member
|
@rustbot label F-derive_smart_pointer |
rustbot
added
the
F-derive_coerce_pointee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delta between what was rolled up (1679c27) and what was later force-pushed and approved (1679c27).
@dingxiangfei2009 pushed after the PR was rolled up, so what was landed on master is not what was finally approved. This is just the delta between those -- nothing really needs re-approval.