rustc book: document how the RUST_TARGET_PATH variable is used #128285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
Jul 27, 2024
jieyouxu
approved these changes
Jul 28, 2024
based on the module comment in rust/compiler/rustc_target/src/spec/mod.rs Fixes rust-lang#128280
lolbinarycat
force-pushed
the
rustc-custom-targets
branch
from
65c2678
to
5eea6d7
Compare
|
r=jieyouxu @jieyouxu like this? |
Ah, that is mostly to signal to other contributors who have r+ rights to approve if PR CI is green, and that we have no outstanding concerns. |
|
In this case nothing here would be tested by CI, so |
bors
added
S-waiting-on-bors
|
r? jieyouxu |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 28, 2024
… r=jieyouxu rustc book: document how the RUST_TARGET_PATH variable is used based on the module comment in rust/compiler/rustc_target/src/spec/mod.rs Fixes rust-lang#128280
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127853 (`#[naked]`: report incompatible attributes) - rust-lang#128228 (Stabilize `const_waker`) - rust-lang#128276 (Add a README to rustbook to explain its purpose) - rust-lang#128279 (Stabilize `is_sorted`) - rust-lang#128282 (bitwise and bytewise methods on `NonZero`) - rust-lang#128285 (rustc book: document how the RUST_TARGET_PATH variable is used) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#127853 (`#[naked]`: report incompatible attributes) - rust-lang#128276 (Add a README to rustbook to explain its purpose) - rust-lang#128279 (Stabilize `is_sorted`) - rust-lang#128282 (bitwise and bytewise methods on `NonZero`) - rust-lang#128285 (rustc book: document how the RUST_TARGET_PATH variable is used) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2024
Rollup merge of rust-lang#128285 - lolbinarycat:rustc-custom-targets, r=jieyouxu rustc book: document how the RUST_TARGET_PATH variable is used based on the module comment in rust/compiler/rustc_target/src/spec/mod.rs Fixes rust-lang#128280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the module comment in
rust/compiler/rustc_target/src/spec/mod.rs
Fixes #128280