-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the reference #128215
Update the reference #128215
Commits on Jul 25, 2024
-
Remove comment about bootstrap.py handling submodules
bootstrap.py handling of submodules was removed in rust-lang#97513.
Configuration menu - View commit details
-
Copy full SHA for 5fa6ede - Browse repository at this point
Copy the full SHA 5fa6edeView commit details -
Remove
pub
from update_existing_submodulesThis is not used anywhere outside this module.
Configuration menu - View commit details
-
Copy full SHA for 6642f8d - Browse repository at this point
Copy the full SHA 6642f8dView commit details -
Clarify comment on update_existing_submodules
This felt like an important point to me.
Configuration menu - View commit details
-
Copy full SHA for 2c6222b - Browse repository at this point
Copy the full SHA 2c6222bView commit details -
Remove argument from the submodules method
The argument was not necessary, since it was only ever passed one value that exists in the config itself.
Configuration menu - View commit details
-
Copy full SHA for 922fdd8 - Browse repository at this point
Copy the full SHA 922fdd8View commit details -
Remove outdated comment about update_submodule
Although its origins were in bootstrap.py, that code in bootstrap.py no longer exists since it was removed.
Configuration menu - View commit details
-
Copy full SHA for 6a449d9 - Browse repository at this point
Copy the full SHA 6a449d9View commit details -
Fix rustbook submodule update location
I put this submodule update in the entirely wrong location. I put it in the `RustcBook` step (for generating src/doc/rustc), when it really should exist for all steps that use the `Rustbook` tool.
Configuration menu - View commit details
-
Copy full SHA for ee75f24 - Browse repository at this point
Copy the full SHA ee75f24View commit details -
Add require_and_update_submodule to ensure submodules exist
This adds a new method `require_and_update_submodule` to replace `update_submodule`. This new method will generate an error if the submodule doesn't actually exist. This replaces some ad-hoc checks that were performing this function. This helps ensure that a good error message is always displayed. This also adds require_and_update_all_submodules which does this for all submodules. Ideally this should not have any change other than better error messages when submodules are missing.
Configuration menu - View commit details
-
Copy full SHA for bbe9056 - Browse repository at this point
Copy the full SHA bbe9056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18aa419 - Browse repository at this point
Copy the full SHA 18aa419View commit details
Commits on Jul 26, 2024
-
Make sure submodules are checked out with
x test
If the submodule is not checked out, then these tests would fail.
Configuration menu - View commit details
-
Copy full SHA for a20db06 - Browse repository at this point
Copy the full SHA a20db06View commit details -
Integrate mdbook-spec for the reference.
This updates the reference which is now using a new mdbook plugin. This requires a little extra work than a normal book because the plugin uses `rustdoc` to generate links to the standard library. It also ensures that the submodule is available for *any* command that uses rustbook, since it is now part of the rustbook workspace.
Configuration menu - View commit details
-
Copy full SHA for 53ef052 - Browse repository at this point
Copy the full SHA 53ef052View commit details
Commits on Jul 27, 2024
-
Fix mistake setting ONLY_HOSTS for Reference.
This was a copy/paste mistake.
Configuration menu - View commit details
-
Copy full SHA for 5ebb821 - Browse repository at this point
Copy the full SHA 5ebb821View commit details -
Configuration menu - View commit details
-
Copy full SHA for f76ab64 - Browse repository at this point
Copy the full SHA f76ab64View commit details -
Consistently use a string to represent a submodule.
This makes it easier to call these functions without needing to form a Path.
Configuration menu - View commit details
-
Copy full SHA for 9b0115c - Browse repository at this point
Copy the full SHA 9b0115cView commit details -
Change the blanket submodule update for library submodules to be requ…
…ired These are required 100% of the time, but they are almost always required for any command that runs Cargo in the main workspace. Ideally, initializing these two standard library submodules would be lazy and only initialized when required (see rust-lang#82653). However, it would require updating these in almost every Step (anything that runs `cargo` in the main workspace).
Configuration menu - View commit details
-
Copy full SHA for 686e27e - Browse repository at this point
Copy the full SHA 686e27eView commit details -
Change prebuilt_llvm_config to not be required.
I misread this one. It is only checking if LLVM needs to be rebuilt. There is code below that handles the case where it is unable to compute the stamp if the source is missing.
Configuration menu - View commit details
-
Copy full SHA for 78ee5d0 - Browse repository at this point
Copy the full SHA 78ee5d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f387eb - Browse repository at this point
Copy the full SHA 0f387ebView commit details -
Rename require_and_update_submodule to require_submodule
Just trying to be a little less verbose here.
Configuration menu - View commit details
-
Copy full SHA for 1c98b8f - Browse repository at this point
Copy the full SHA 1c98b8fView commit details