Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reference #128215

Merged
merged 17 commits into from
Jul 28, 2024
Merged

Update the reference #128215

merged 17 commits into from
Jul 28, 2024

Commits on Jul 25, 2024

  1. Remove comment about bootstrap.py handling submodules

    bootstrap.py handling of submodules was removed in
    rust-lang#97513.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5fa6ede View commit details
    Browse the repository at this point in the history
  2. Remove pub from update_existing_submodules

    This is not used anywhere outside this module.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6642f8d View commit details
    Browse the repository at this point in the history
  3. Clarify comment on update_existing_submodules

    This felt like an important point to me.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2c6222b View commit details
    Browse the repository at this point in the history
  4. Remove argument from the submodules method

    The argument was not necessary, since it was only ever passed one
    value that exists in the config itself.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    922fdd8 View commit details
    Browse the repository at this point in the history
  5. Remove outdated comment about update_submodule

    Although its origins were in bootstrap.py, that code in bootstrap.py
    no longer exists since it was removed.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6a449d9 View commit details
    Browse the repository at this point in the history
  6. Fix rustbook submodule update location

    I put this submodule update in the entirely wrong location. I put it in
    the `RustcBook` step (for generating src/doc/rustc), when it really
    should exist for all steps that use the `Rustbook` tool.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ee75f24 View commit details
    Browse the repository at this point in the history
  7. Add require_and_update_submodule to ensure submodules exist

    This adds a new method `require_and_update_submodule` to replace
    `update_submodule`. This new method will generate an error if the
    submodule doesn't actually exist. This replaces some ad-hoc checks that
    were performing this function. This helps ensure that a good error
    message is always displayed.
    
    This also adds require_and_update_all_submodules which does this for
    all submodules.
    
    Ideally this should not have any change other than better error messages
    when submodules are missing.
    ehuss committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bbe9056 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    18aa419 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Make sure submodules are checked out with x test

    If the submodule is not checked out, then these tests would fail.
    ehuss committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a20db06 View commit details
    Browse the repository at this point in the history
  2. Integrate mdbook-spec for the reference.

    This updates the reference which is now using a new mdbook plugin. This
    requires a little extra work than a normal book because the plugin uses
    `rustdoc` to generate links to the standard library. It also ensures
    that the submodule is available for *any* command that uses rustbook,
    since it is now part of the rustbook workspace.
    ehuss committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    53ef052 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Fix mistake setting ONLY_HOSTS for Reference.

    This was a copy/paste mistake.
    ehuss committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5ebb821 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f76ab64 View commit details
    Browse the repository at this point in the history
  3. Consistently use a string to represent a submodule.

    This makes it easier to call these functions without needing to form a
    Path.
    ehuss committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9b0115c View commit details
    Browse the repository at this point in the history
  4. Change the blanket submodule update for library submodules to be requ…

    …ired
    
    These are required 100% of the time, but they are almost always required
    for any command that runs Cargo in the main workspace.
    
    Ideally, initializing these two standard library submodules would be
    lazy and only initialized when required (see
    rust-lang#82653). However, it would require
    updating these in almost every Step (anything that runs `cargo` in the
    main workspace).
    ehuss committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    686e27e View commit details
    Browse the repository at this point in the history
  5. Change prebuilt_llvm_config to not be required.

    I misread this one. It is only checking if LLVM needs to be rebuilt.
    There is code below that handles the case where it is unable to compute
    the stamp if the source is missing.
    ehuss committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    78ee5d0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0f387eb View commit details
    Browse the repository at this point in the history
  7. Rename require_and_update_submodule to require_submodule

    Just trying to be a little less verbose here.
    ehuss committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    1c98b8f View commit details
    Browse the repository at this point in the history