-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazify TargetOptions::*link_args
fields
#127992
Conversation
These commits modify compiler targets. |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Lazify `TargetOptions::*link_args` fields This PR lazify the link args by introducing `MaybeLazy`, a 3-way lazy container (borrowed, owned and lazied state). Split from rust-lang#122703 r? `@petrochenkov`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (f36d603): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary 6.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.644s -> 769.722s (0.27%) |
I'm going to make a hard decision and close this as well. My apologies for the wasted effort, I'm sure this was pretty annoying to implement due to the sheer number of the target specs needing modifications. I'm not if we could recycle these patches later. |
This PR lazify the link args by introducing
MaybeLazy
, a 3-way lazy container (borrowed, owned and lazied state).Split from #122703
r? @petrochenkov