Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set result during finish() in debug builders #127946

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Always set result during finish() in debug builders #127946

merged 1 commit into from
Jul 27, 2024

Commits on Jul 26, 2024

  1. Always set result during finish() in debug builders 

    Most functions for format builders set `self.result` after writing
strings. This ensures that any further writing fails immediately rather
than trying to write again.

A few `.finish()` methods did have this same behavior, so make it
consistent here.
    @tgross35
    tgross35 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    cc9da0b View commit details
    Browse the repository at this point in the history