collect doc alias as tips during resolution

[bvanjoi]

Close #124273

Collect the symbol in the doc alias attributes and provide a tip when a match is found.

r? @estebank

[petrochenkov]

In general I'd prefer to maybe not do this at all for the local crate.
It will simplify things and avoid doing work on a good path.
The crate authors are the same people who write the doc alias attributes, so these hints are unlikely to be useful for them.

[bvanjoi]

I'd prefer to maybe not do this at all for the local crate.

Agree and accept this suggestion.

@rustbot ready

[lolbinarycat]

@bvanjoi triage here, any interest in rebasing this?

[alex-semenyuk]

@bvanjoi
Form wg-triage. Could you please rebase that it will be ready for review?

[bvanjoi]

Rebased. @rustbot ready

[bvanjoi]

Update: Fixes the incorrect submodule...

[wesleywiser]

Hi @estebank could you take a look at this when you get a chance? Thanks 🙂

[jieyouxu]

Maybe r? @petrochenkov (or reroll)?

[bvanjoi]

@rustbot ready

[petrochenkov]

r=me with an explanation #127721 (comment), not just for rev but for what the code intends to do in general.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[petrochenkov]

@bors r+

[bors]

📌 Commit 097b7a2 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 097b7a2 with merge 87b4541...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 87b4541 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2b96ddc (parent) -> 87b4541 (this PR)

Test differences

Show 10 test diffs

Stage 1

• [ui] tests/ui/attributes/use-doc-alias-name.rs: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/attributes/use-doc-alias-name.rs: [missing] -> pass (J1)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 87b454156998b945cf161c951f0fbc20ac292cf6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 4341.3s -> 5873.7s (35.3%)
2. x86_64-apple-1: 6966.2s -> 9260.8s (32.9%)
3. dist-apple-various: 7766.6s -> 9006.8s (16.0%)
4. dist-arm-linux: 5206.7s -> 4664.2s (-10.4%)
5. dist-i686-linux: 5660.3s -> 6107.3s (7.9%)
6. dist-aarch64-apple: 5258.5s -> 5662.1s (7.7%)
7. x86_64-gnu-llvm-19-3: 6639.2s -> 7142.6s (7.6%)
8. mingw-check: 1186.2s -> 1271.8s (7.2%)
9. x86_64-mingw-2: 7466.1s -> 7035.1s (-5.8%)
10. dist-riscv64-linux: 5017.0s -> 5294.3s (5.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (87b4541): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[0.4%, 6.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.539s -> 775.275s (-0.03%)
Artifact size: 365.50 MiB -> 365.51 MiB (0.00%)