Migrate `crate-hash-rustc-version` to `rmake` #127693

Rejyr · 2024-07-13T18:30:09Z

try-job: x86_64-gnu-llvm-18
try-job: dist-x86_64-linux

rustbot · 2024-07-13T18:30:18Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu

Thanks, looks good in general, just some minor nits. I'll run your PR through a few try-jobs to check.

tests/run-make/crate-hash-rustc-version/rmake.rs

jieyouxu · 2024-07-14T09:59:20Z

tests/run-make/crate-hash-rustc-version/rmake.rs

+    // a.rs is a dylib
+    rustc().input("a.rs").crate_type("dylib").args(&flags).run();
+
+    // Write symbols to disk.


Question: is this accurate, or did we just write to stdout?

Writing to disk was a part of the Makefile implementation. I'll update the comment to align with the rmake implementation.

tests/run-make/crate-hash-rustc-version/rmake.rs

jieyouxu · 2024-07-14T10:02:54Z

@bors try

jieyouxu · 2024-07-14T10:02:59Z

@rustbot author

…on-rmake, r=<try> Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-msvc try-job: aarch64-apple try-job: dist-x86_64-linux

bors · 2024-07-14T10:04:04Z

⌛ Trying commit 3f904e0 with merge 3804d28...

bors · 2024-07-14T11:04:42Z

💔 Test failed - checks-actions

Rejyr · 2024-07-14T16:55:12Z

@rustbot review

tests/run-make/crate-hash-rustc-version/rmake.rs

jieyouxu · 2024-07-16T08:15:45Z

@bors try

bors · 2024-07-16T08:16:56Z

⌛ Trying commit 50f3293 with merge 959b44f...

…on-rmake, r=<try> Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-msvc try-job: aarch64-apple try-job: dist-x86_64-linux

bors · 2024-07-16T08:17:43Z

💔 Test failed - checks-actions

…on-rmake, r=<try> Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-msvc try-job: aarch64-apple try-job: dist-x86_64-linux

bors · 2024-07-16T09:54:17Z

💔 Test failed - checks-actions

tests/run-make/crate-hash-rustc-version/Makefile

tests/run-make/crate-hash-rustc-version/rmake.rs

Rejyr · 2024-07-18T15:01:38Z

@rustbot review

Also needs bors try.

jieyouxu · 2024-07-18T15:11:23Z

@bors try

…on-rmake, r=<try> Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-gnu-llvm-18 try-job: dist-x86_64-linux

bors · 2024-07-18T15:12:37Z

⌛ Trying commit eea6502 with merge f71476d...

bors · 2024-07-18T17:21:30Z

☀️ Try build successful - checks-actions
Build commit: f71476d (f71476d6dfb7dd7df0a265a59ce737ac54cdb97d)

jieyouxu

Thank you!

jieyouxu · 2024-07-19T14:14:31Z

@bors r+

bors · 2024-07-19T14:14:33Z

📌 Commit eea6502 has been approved by jieyouxu

It is now in the queue for this repository.

…sion-rmake, r=jieyouxu Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: x86_64-gnu-llvm-18 try-job: dist-x86_64-linux

Rollup of 8 pull requests Successful merges: - rust-lang#123196 (Add Process support for UEFI) - rust-lang#127523 (Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake) - rust-lang#127556 (Replace a long inline "autoref" comment with method docs) - rust-lang#127693 (Migrate `crate-hash-rustc-version` to `rmake`) - rust-lang#127866 (Conditionally build `wasm-component-ld` ) - rust-lang#127918 (Safely enforce thread name requirements) - rust-lang#127948 (fixes panic error `index out of bounds` in conflicting error) - rust-lang#127980 (Avoid ref when using format! in compiler) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123196 (Add Process support for UEFI) - rust-lang#127556 (Replace a long inline "autoref" comment with method docs) - rust-lang#127693 (Migrate `crate-hash-rustc-version` to `rmake`) - rust-lang#127866 (Conditionally build `wasm-component-ld` ) - rust-lang#127918 (Safely enforce thread name requirements) - rust-lang#127948 (fixes panic error `index out of bounds` in conflicting error) - rust-lang#127980 (Avoid ref when using format! in compiler) - rust-lang#127984 (Avoid ref when using format! in src) - rust-lang#127987 (More accurate suggestion for `-> Box<dyn Trait>` or `-> impl Trait`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127693 - Rejyr:migrate-crate-hash-rustc-version-rmake, r=jieyouxu Migrate `crate-hash-rustc-version` to `rmake` Part of rust-lang#121876. r? ``@jieyouxu`` try-job: x86_64-gnu-llvm-18 try-job: dist-x86_64-linux

rustbot assigned jieyouxu Jul 13, 2024

Kobzol mentioned this pull request Jul 14, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

jieyouxu approved these changes Jul 14, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2024

This comment has been minimized.

Sign in to view

Rejyr force-pushed the migrate-crate-hash-rustc-version-rmake branch from 3f904e0 to 33f651b Compare July 14, 2024 15:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2024

Oneirical reviewed Jul 15, 2024

View reviewed changes

tests/run-make/crate-hash-rustc-version/rmake.rs Outdated Show resolved Hide resolved

Oneirical reviewed Jul 15, 2024

View reviewed changes

tests/run-make/crate-hash-rustc-version/rmake.rs Outdated Show resolved Hide resolved

Rejyr force-pushed the migrate-crate-hash-rustc-version-rmake branch from d409235 to 50f3293 Compare July 15, 2024 23:53

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024

This comment has been minimized.

Sign in to view

Rejyr commented Jul 16, 2024

View reviewed changes

tests/run-make/crate-hash-rustc-version/Makefile Show resolved Hide resolved

Rejyr force-pushed the migrate-crate-hash-rustc-version-rmake branch from 50f3293 to 4c6f4d6 Compare July 16, 2024 15:28

jieyouxu reviewed Jul 17, 2024

View reviewed changes

tests/run-make/crate-hash-rustc-version/rmake.rs Outdated Show resolved Hide resolved

Rejyr added 2 commits July 17, 2024 06:49

Migrate crate-hash-rustc-version to rmake

ec6e07b

Use llvm-readobj for run-make/crate-hash-rustc-version

eea6502

Rejyr force-pushed the migrate-crate-hash-rustc-version-rmake branch from 4c6f4d6 to eea6502 Compare July 17, 2024 10:49

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

jieyouxu approved these changes Jul 19, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024

tgross35 mentioned this pull request Jul 19, 2024

Rollup of 8 pull requests #127991

Closed

matthiaskrgr mentioned this pull request Jul 20, 2024

Rollup of 9 pull requests #127998

Merged

bors merged commit aa6ae4b into rust-lang:master Jul 20, 2024

rustbot added this to the 1.81.0 milestone Jul 20, 2024

Uh oh!

Migrate crate-hash-rustc-version to rmake #127693

Migrate crate-hash-rustc-version to rmake #127693

Uh oh!

Conversation

Rejyr commented Jul 13, 2024 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 13, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

Rejyr Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 14, 2024

Uh oh!

jieyouxu commented Jul 14, 2024

Uh oh!

bors commented Jul 14, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 14, 2024

Uh oh!

Rejyr commented Jul 14, 2024

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 16, 2024

Uh oh!

bors commented Jul 16, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 16, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 16, 2024

Uh oh!

Uh oh!

Uh oh!

Rejyr commented Jul 18, 2024

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

bors commented Jul 18, 2024

Uh oh!

bors commented Jul 18, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 19, 2024

Uh oh!

bors commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Migrate `crate-hash-rustc-version` to `rmake` #127693

Migrate `crate-hash-rustc-version` to `rmake` #127693

Rejyr commented Jul 13, 2024 •

edited by jieyouxu

Loading