Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak some structured suggestions to be more verbose and accurate #127301

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Tweak some structured suggestions to be more verbose and accurate #127301

merged 9 commits into from
Jul 4, 2024

Commits on Jul 4, 2024

  1. Adjust rustdoc automatic link suggestion 

    Use more accurate spans for multipart suggestion.
    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    140392b View commit details
    Browse the repository at this point in the history

  2. Better span for "make binding mutable" suggestion

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    89ecae5 View commit details
    Browse the repository at this point in the history

  3. Better suggestion span for missing type parameter

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f63d2bc View commit details
    Browse the repository at this point in the history

  4. Fix &mut removal suggestion

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9344779 View commit details
    Browse the repository at this point in the history

  5. Properly handle removal suggestion rendering 

    Do not leave a `+ ` line with only whitespace. In reality, the user will want to remove the entire line.
    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a06a18a View commit details
    Browse the repository at this point in the history

  6. Use shorter span for float literal suggestion

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2699d81 View commit details
    Browse the repository at this point in the history

  7. More accurate mutability suggestion

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ff92ab0 View commit details
    Browse the repository at this point in the history

  8. Tweak slice and as_deref suggestion span 

    Use multispan suggestion.
    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8ea1066 View commit details
    Browse the repository at this point in the history

  9. Tweak raw-pointer field access and array indexing suggestions

    @estebank
    estebank committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a5e7da0 View commit details
    Browse the repository at this point in the history