Make inline suggestions no longer be the default

[estebank]

Make the default suggestions show the full patch output instead of trying to render inline.

Before

error: almost complete ascii range
  --> tests/ui/almost_complete_range.rs:17:17
   |
LL |         let _ = ('a') ..'z';
   |                 ^^^^^^--^^^
   |                       |
   |                       help: use an inclusive range: `..=`
   |
   = note: `-D clippy::almost-complete-range` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::almost_complete_range)]`

After

error: almost complete ascii range
  --> tests/ui/almost_complete_range.rs:17:17
   |
LL |         let _ = ('a') ..'z';
   |                 ^^^^^^^^^^^
   |
   = note: `-D clippy::almost-complete-range` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::almost_complete_range)]`
help: use an inclusive range
   |
LL |         let _ = ('a') ..='z';
   |                       ~~~

The inline suggestions output has worse readability than the "verbose" output, and it also (as evidenced in the diff of this PR) tends to hide when the suggestion span is slightly off. Backing off of the inline suggestions will also make it easier to migrate to annotate-snippets, as it will be one fewer special case to handle.

[rustbot]

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[estebank]

I noticed a bunch of mistakes in current suggestions thanks to the new output, but all of those can go on other PRs.

[estebank]

This clippy suggestions are just plain wrong, right?

[Alexendoo]

It's the old pattern syntax for when MSRV is set to the ancient times

rust/src/tools/clippy/tests/ui/almost_complete_range.rs

Lines 70 to 78 in 2b90614

	#[clippy::msrv = "1.25"]
	fn _under_msrv() {
	let _ = match 'a' {
	'a'..'z' => 1,
	'A'..'Z' => 2,
	'0'..'9' => 3,
	_ => 4,
	};
	}

[estebank]

Interesting, we're missing an underline here.

[flip1995]

Does this happen, because we're replacing the entire line? The clippy suggestion probably doesn't add the .await, but suggests to remove the CustomFutureType and add CustomFutureType.await.

[estebank]

Clippyy needs to have better messages for these suggestions

[blyxyas]

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/On.20short.20help.20messages

[bors]

☔ The latest upstream changes (presumably #127326) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

HIR ty lowering was modified

cc @fmease

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

Some changes occurred in tests/ui/check-cfg

cc @Urgau

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in match checking

cc @Nadrieril

[estebank]

This PR is too big as is, but the diff helps identify specific suggestions that are currently not-perfect, or flat-out wrong. I'll try to fix those things one at a time in separate PRs, making this PR smaller and smaller over time.

[bors]

☔ The latest upstream changes (presumably #127008) made this pull request unmergeable. Please resolve the merge conflicts.