Skip to content

Migrate dylib-chain, rlib-chain, issue-47384, msvc-opt-minsize and test-harness run-make tests to ui/rmake #127044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2024
Merged

Migrate dylib-chain, rlib-chain, issue-47384, msvc-opt-minsize and test-harness run-make tests to ui/rmake #127044

merged 5 commits into from
Jul 3, 2024

Conversation

@Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jun 27, 2024 •
edited
Loading

Part of #121876 and the associated Google Summer of Code project.

try-job: x86_64-msvc
try-job: aarch64-apple

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the fantestic-journey branch from 95ba6d7 to 2019f15 Compare June 27, 2024 15:56
@Kobzol Kobzol mentioned this pull request Jun 27, 2024
Closed
@Kobzol
Copy link
Member

Kobzol commented Jun 27, 2024

r? @Kobzol

@bors try

@rustbot rustbot assigned Kobzol and unassigned jieyouxu Jun 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2024
@bors
Auto merge of rust-lang#127044 - Oneirical:fantestic-journey, r=<try>
27ea1de 
Migrate `dylib-chain`, `rlib-chain`, `issue-47384`, `msvc-opt-minsize` and `test-harness` `run-make` tests to ui/rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

`issue-47384` demands a Windows/Apple try-job.

try-job: x86_64-msvc
try-job: aarch64-apple
@bors
Copy link
Collaborator

bors commented Jun 27, 2024

⌛ Trying commit 2019f15 with merge 27ea1de...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024
@Oneirical Oneirical force-pushed the fantestic-journey branch from 2019f15 to ea53274 Compare June 27, 2024 20:42
@Oneirical
Copy link
Contributor Author

Ignore directive re-added with reason. @rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2024
Kobzol
Kobzol reviewed Jun 27, 2024
View reviewed changes
@Kobzol
Copy link
Member

Kobzol commented Jun 27, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024
@Oneirical Oneirical force-pushed the fantestic-journey branch from ea53274 to 02a5002 Compare June 28, 2024 14:05
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 28, 2024
@bors
Copy link
Collaborator

bors commented Jun 28, 2024

📌 Commit 35afb92 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024
@bors
Copy link
Collaborator

bors commented Jun 29, 2024

☔ The latest upstream changes (presumably #127121) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2024
@Oneirical Oneirical force-pushed the fantestic-journey branch from 35afb92 to 45313a6 Compare July 2, 2024 15:38
@Oneirical
Copy link
Contributor Author

Did nothing except resolve merge conflict, please re-approve.

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2024
jieyouxu
jieyouxu approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jieyouxu
Copy link
Member

jieyouxu commented Jul 3, 2024

@bors r=Kobzol,jieyouxu

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

📌 Commit 45313a6 has been approved by Kobzol,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2024
@bors
Copy link
Collaborator

bors commented Jul 3, 2024

⌛ Testing commit 45313a6 with merge aa1d4f6...

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol,jieyouxu
Pushing aa1d4f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2024
@bors bors merged commit aa1d4f6 into rust-lang:master Jul 3, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 3, 2024
This was referenced Jul 3, 2024
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa1d4f6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.3%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.3% [2.0%, 6.5%] 2
Regressions ❌
(secondary)		 2.3% [1.4%, 3.5%] 10
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.3% [2.0%, 6.5%] 2

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.4%, 0.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 742.115s -> 724.291s (-2.40%)
Artifact size: 327.64 MiB -> 327.61 MiB (-0.01%)

@Oneirical Oneirical deleted the fantestic-journey branch July 4, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Kobzol Kobzol

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

No open projects
Oxidizing run-make tests
Status: Done

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Oneirical @rustbot @rust-log-analyzer @Kobzol @bors @jieyouxu @rust-timer