Rollup of 9 pull requests #126891

matthiaskrgr · 2024-06-24T04:27:17Z

Successful merges:

Add hard error and migration lint for unsafe attrs #126177 (Add hard error and migration lint for unsafe attrs)
Promote loongarch64-unknown-linux-musl to Tier 2 with host tools #126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools)
For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it. #126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.)
Implement use<> formatting in rustfmt #126754 (Implement use<> formatting in rustfmt)
std::unix::fs: copy simplification for apple. #126807 (std::unix::fs: copy simplification for apple.)
Weekly cargo update #126845 (Weekly cargo update)
Fix 32-bit Arm reg classes by hierarchically sorting them #126849 (Fix 32-bit Arm reg classes by hierarchically sorting them)
std::unix::os::home_dir: fallback's optimisation. #126854 (std::unix::os::home_dir: fallback's optimisation.)
Remove stray println from rustfmt's rewrite_static #126888 (Remove stray println from rustfmt's rewrite_static)

r? @ghost
@rustbot modify labels: rollup

since we do support from macOs Sierra, we avoid the little runtime overhead with the fclonefileat symbol check.

Locking 9 packages to latest compatible versions Updating clap_complete v4.5.5 -> v4.5.6 Updating displaydoc v0.2.4 -> v0.2.5 Removing icu_collections v1.5.0 Removing icu_normalizer v1.5.0 Removing icu_normalizer_data v1.5.0 Removing icu_properties v1.5.0 Removing icu_properties_data v1.5.0 Downgrading idna v1.0.0 -> v0.5.0 (latest: v1.0.1) Updating lazy_static v1.4.0 -> v1.5.0 Updating miniz_oxide v0.7.3 -> v0.7.4 Updating proc-macro2 v1.0.85 -> v1.0.86 Updating syn v2.0.66 -> v2.0.67 Adding unicode-bidi v0.3.15 Updating url v2.5.1 -> v2.5.2 Removing utf16_iter v1.0.5 Removing utf8_iter v1.0.4 Removing write16 v1.0.0 note: pass `--verbose` to see 85 unchanged dependencies behind latest

… semicolon ';' at the end of it. fixes rust-lang#126222

we're using a guaranteed initialised field on success.

MCP: rust-lang/compiler-team#753

…r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

…-Simulacrum Promote loongarch64-unknown-linux-musl to Tier 2 with host tools MCP: rust-lang/compiler-team#753 Tracking issue: rust-lang#122592 try-job: dist-loongarch64-musl

For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it. For [E0308]: mismatched types, when expr is in an arm's body, and it is the end expr without a semicolon of the block, not add semicolon ';' at the end of it. fixes rust-lang#126222

…ebcartwright Implement `use<>` formatting in rustfmt This PR implements formatting for precise-capturing `use<>` syntax as proposed in rust-lang#126753. The syntax is implemented as-if the `use<>` bound were a trait bound but with the `use` keyword as its path segment identifier. I opted to develop this in the rust-lang/rust tree since I'm not certain when the next rustfmt subtree sync is going to be, and I'd rather not block landing nightly support for `use<>` on something I have no control over. If ``@rust-lang/rustfmt`` would rather I move this PR over to that repository, then I would at least like to know when the next rustfmt->rust subtree sync is going to be, since stabilizing `precise_capturing` without formatting will be disruptive. This implementation is otherwise rather straightforward. Tracking: - rust-lang#123432

…Mark-Simulacrum std::unix::fs: copy simplification for apple. since we do support from macOs Sierra, we avoid the little runtime overhead with the fclonefileat symbol check.

…ulacrum Weekly `cargo update` Automation to keep dependencies in `Cargo.lock` current. The following is the output from `cargo update`: ```txt Locking 9 packages to latest compatible versions Updating clap_complete v4.5.5 -> v4.5.6 Updating displaydoc v0.2.4 -> v0.2.5 Removing icu_collections v1.5.0 Removing icu_normalizer v1.5.0 Removing icu_normalizer_data v1.5.0 Removing icu_properties v1.5.0 Removing icu_properties_data v1.5.0 Downgrading idna v1.0.0 -> v0.5.0 (latest: v1.0.1) Updating lazy_static v1.4.0 -> v1.5.0 Updating miniz_oxide v0.7.3 -> v0.7.4 Updating proc-macro2 v1.0.85 -> v1.0.86 Updating syn v2.0.66 -> v2.0.67 Adding unicode-bidi v0.3.15 Updating url v2.5.1 -> v2.5.2 Removing utf16_iter v1.0.5 Removing utf8_iter v1.0.4 Removing write16 v1.0.0 note: pass `--verbose` to see 85 unchanged dependencies behind latest ```

…arm-low-dregs, r=Amanieu Fix 32-bit Arm reg classes by hierarchically sorting them We were rejecting legal `asm!` because we were asking for the "greatest" feature that includes a register class, instead of the "least" feature that includes a register class. This was only revealed on certain 32-bit Arm targets because not all have the same register limitations. This is a somewhat hacky solution, but other solutions would require potentially rearchitecting how the internals of parsing or rejecting register classes work for all targets. Fixes rust-lang#126797 r? ``@Amanieu``

… r=Mark-Simulacrum std::unix::os::home_dir: fallback's optimisation. we're using a guaranteed initialised field on success.

…g, r=dtolnay Remove stray println from rustfmt's `rewrite_static` r? `@calebcartwright` `@ytmimi` -- though anyone should probably r+ this so it gets into nightly sooner than later, since it's obviously wrong. This can just be fixed in-tree, since I don't think we want to wait until the next sync to fix this. Fix rust-lang/rustfmt#6210 Fix rust-lang#126887

matthiaskrgr · 2024-06-24T04:27:31Z

@bors r+ rollup=never p=9

bors · 2024-06-24T04:27:33Z

📌 Commit b94d275 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-06-24T05:06:34Z

⌛ Testing commit b94d275 with merge 2c243d9...

bors · 2024-06-24T07:17:04Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2c243d9 to master...

rust-timer · 2024-06-24T07:19:34Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#126177	Add hard error and migration lint for unsafe attrs	`63831c9e84d565161d65e06884a43868e052bab8` (link)
#126298	Promote loongarch64-unknown-linux-musl to Tier 2 with host …	`f1a9f627a311932acfdfaabb41857a49aeffefcb` (link)
#126455	For [E0308]: mismatched types, when expr is in an arm's bod…	`2374131a7fb94c42826a12db462fde4db8cca834` (link)
#126754	Implement `use<>` formatting in rustfmt	`e7e363a859db9c5d479586b35ed580cdb8ae38e2` (link)
#126807	std::unix::fs: copy simplification for apple.	`3acf720a7c72cfa2d41ee0dbbcdd98f913b7a499` (link)
#126845	Weekly `cargo update`	`efb88fda5f5637c135beacf03c14d983749a6f5b` (link)
#126849	Fix 32-bit Arm reg classes by hierarchically sorting them	`0cc976d09406f357c70d39460c5786bfd3e2d48d` (link)
#126854	std::unix::os::home_dir: fallback's optimisation.	`b393466980f9b0ed15f2ce18d2552632199f912d` (link)
#126888	Remove stray println from rustfmt's `rewrite_static`	`991d7ee3d05422a236a34884044af6a22477e432` (link)

previous master: d49994b060

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-06-24T09:21:21Z

Finished benchmarking commit (2c243d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 5.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.2%	[5.2%, 5.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -7.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.3%	[-8.2%, -6.5%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	4
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	35
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	4

Bootstrap: 693.26s -> 692.382s (-0.13%)
Artifact size: 326.75 MiB -> 326.78 MiB (0.01%)

@Kobzol

Update Rust toolchain from nightly-2024-06-24 to nightly-2024-06-25 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@bcf94de up to rust-lang@6b0f4b5. The log for this commit range is: rust-lang@6b0f4b5ec3 Auto merge of rust-lang#126914 - compiler-errors:rollup-zx0hchm, r=compiler-errors rust-lang@16bd6e25e1 Rollup merge of rust-lang#126911 - oli-obk:do_not_count_errors, r=compiler-errors rust-lang@59c258f51f Rollup merge of rust-lang#126909 - onur-ozkan:add-kobzol, r=matthiaskrgr rust-lang@85eb835a14 Rollup merge of rust-lang#126904 - GrigorenkoPV:nonzero-fixme, r=joboet rust-lang@a7721a0373 Rollup merge of rust-lang#126899 - GrigorenkoPV:suggest-const-block, r=davidtwco rust-lang@9ce2a070b3 Rollup merge of rust-lang#126682 - Zalathar:coverage-attr, r=lcnr rust-lang@49bdf460a2 Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting, r=compiler-errors rust-lang@46e43984d1 Rollup merge of rust-lang#126413 - matthiaskrgr:crshmsg, r=oli-obk rust-lang@ed460d2eaa Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco rust-lang@c77dc28f87 Rollup merge of rust-lang#125082 - kpreid:const-uninit, r=dtolnay rust-lang@faa28be2f1 Rollup merge of rust-lang#124712 - Enselic:deprecate-inline-threshold, r=pnkfelix rust-lang@00e5f5886a Rollup merge of rust-lang#124460 - long-long-float:show-notice-about-enum-with-debug, r=pnkfelix rust-lang@d8d5732456 Auto merge of rust-lang#126784 - scottmcm:smaller-terminator, r=compiler-errors rust-lang@13fca73f49 Replace `MaybeUninit::uninit_array()` with array repeat expression. rust-lang@5a3e2a4e92 Auto merge of rust-lang#126523 - joboet:the_great_big_tls_refactor, r=Mark-Simulacrum rust-lang@45261ff2ec add @Kobzol to bootstrap team for triagebot rust-lang@84474a25a4 Small fixme in core now that NonZero is generic rust-lang@50a02ed789 std: fix wasm builds rust-lang@8fc6b3de19 Separate the mir body lifetime from the other lifetimes rust-lang@1c4d0ced58 Separate the lifetimes of the `BorrowckInferCtxt` from the other borrowed items rust-lang@d371d17496 Auto merge of rust-lang#126900 - matthiaskrgr:rollup-24ah97b, r=matthiaskrgr rust-lang@8ffb5f936a compiletest: make the crash test error message abit more informative rust-lang@a80ee9159b Rollup merge of rust-lang#126882 - estebank:multiline-order, r=WaffleLapkin rust-lang@8bfde609e2 Rollup merge of rust-lang#126414 - ChrisDenton:target-known, r=Nilstrieb rust-lang@94b9ea417d Rollup merge of rust-lang#126213 - zachs18:atomicbool-u8-i8-from-ptr-alignment, r=Nilstrieb rust-lang@9d24ecc37b Rollup merge of rust-lang#125241 - Veykril:tool-rust-analyzer, r=davidtwco rust-lang@ba5ec1fc5c Suggest inline const blocks for array initialization rust-lang@06c072f158 Auto merge of rust-lang#126788 - GuillaumeGomez:migrate-rustdoc-tests-syntax, r=fmease,oli-obk rust-lang@1852141219 coverage: Bless coverage attribute tests rust-lang@b7c057c9b2 coverage: Always error on `#[coverage(..)]` in unexpected places rust-lang@a000fa8b54 coverage: Tighten validation of `#[coverage(off)]` and `#[coverage(on)]` rust-lang@b5dfeba0e1 coverage: Forbid multiple `#[coverage(..)]` attributes rust-lang@6909feab8e Allow numbers in rustdoc tests commands rust-lang@4e258bb4c3 Fix tidy issue for rustdoc tests commands rust-lang@51fedf65ff Remove commands duplication between `compiletest` and `tests/rustdoc` rust-lang@1b67035579 Update `tests/rustdoc` to new test syntax rust-lang@d3ec92e16e Move `tests/rustdoc` testsuite to `//@` syntax rust-lang@2c243d9570 Auto merge of rust-lang#126891 - matthiaskrgr:rollup-p6dl1gk, r=matthiaskrgr rust-lang@b94d2754b5 Rollup merge of rust-lang#126888 - compiler-errors:oops-debug-printing, r=dtolnay rust-lang@9892b3e9fe Rollup merge of rust-lang#126854 - devnexen:std_unix_os_fallback_upd, r=Mark-Simulacrum rust-lang@3108dfaced Rollup merge of rust-lang#126849 - workingjubilee:correctly-classify-arm-low-dregs, r=Amanieu rust-lang@dcace866f0 Rollup merge of rust-lang#126845 - rust-lang:cargo_update, r=Mark-Simulacrum rust-lang@21850f5bd8 Rollup merge of rust-lang#126807 - devnexen:copy_file_macos_simpl, r=Mark-Simulacrum rust-lang@b24e3df0df Rollup merge of rust-lang#126754 - compiler-errors:use-rustfmt, r=calebcartwright rust-lang@ad0531ae0d Rollup merge of rust-lang#126455 - surechen:fix_126222, r=estebank rust-lang@7babf99ea9 Rollup merge of rust-lang#126298 - heiher:loongarch64-musl-ci, r=Mark-Simulacrum rust-lang@9a591ea1ce Rollup merge of rust-lang#126177 - carbotaniuman:unsafe_attr_errors, r=jieyouxu rust-lang@25446c25fc Remove stray println from rustfmt rust-lang@d49994b060 Auto merge of rust-lang#126023 - amandasystems:you-dropped-this-again, r=nikomatsakis rust-lang@a23917cfd0 Add hard error and migration lint for unsafe attrs rust-lang@284437d434 Special case when a code line only has multiline span starts rust-lang@f1be59fa72 SmartPointer derive-macro rust-lang@a426d6fdf0 Implement use<> formatting in rustfmt rust-lang@16fef40896 Promote loongarch64-unknown-linux-musl to Tier 2 with host tools rust-lang@03d73fa6ba ci: Add support for dist-loongarch64-musl rust-lang@fc50acae90 fix build rust-lang@bd9ce3e074 std::unix::os::home_dir: fallback's optimisation. rust-lang@0d8f734172 compiler: Fix arm32 asm issues by hierarchically sorting reg classes rust-lang@e8b5ba1111 For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it. rust-lang@990535723d cargo update rust-lang@b28efb11af Save 2 pointers in `TerminatorKind` (96 → 80 bytes) rust-lang@65530ba100 std::unix::fs: copy simplification for apple. rust-lang@339015920d Add `rust_analyzer` as a predefined tool rust-lang@3f2f8438b4 Ensure we don't accidentally succeed when we want to report an error rust-lang@32f9b8bf76 std: rename module for clarity rust-lang@35f050b8da std: update TLS module documentation rust-lang@b2f29edc81 std: use the `c_int` from `core::ffi` instead of `libc` rust-lang@d70f071392 std: simplify `#[cfg]`s for TLS rust-lang@d630f5da7a Show notice about "never used" for enum rust-lang@f3facf1175 std: refactor the TLS implementation rust-lang@f5f067bf9d Deprecate no-op codegen option `-Cinline-threshold=...` rust-lang@651ff643ae Fix typo in `-Cno-stack-check` deprecation warning rust-lang@3af624272a rustc_codegen_ssa: Remove unused ModuleConfig::inline_threshold rust-lang@34e6ea1446 Tier 2 std support must always be known rust-lang@2d4cb7aa5a Update docs for AtomicU8/I8. rust-lang@7885c7b7b2 Update safety docs for AtomicBool::from_ptr. rust-lang@7b5b7a7010 Remove confusing `use_polonius` flag and do less cloning Co-authored-by: tautschnig <1144736+tautschnig@users.noreply.github.com>

devnexen and others added 20 commits June 21, 2024 21:22

std::unix::fs: copy simplification for apple.

65530ba

since we do support from macOs Sierra, we avoid the little runtime overhead with the fclonefileat symbol check.

For [E0308]: mismatched types, when expr is in an arm's body, not add…

e8b5ba1

… semicolon ';' at the end of it. fixes rust-lang#126222

compiler: Fix arm32 asm issues by hierarchically sorting reg classes

0d8f734

std::unix::os::home_dir: fallback's optimisation.

bd9ce3e

we're using a guaranteed initialised field on success.

fix build

fc50aca

ci: Add support for dist-loongarch64-musl

03d73fa

Promote loongarch64-unknown-linux-musl to Tier 2 with host tools

16fef40

MCP: rust-lang/compiler-team#753

Implement use<> formatting in rustfmt

a426d6f

Add hard error and migration lint for unsafe attrs

a23917c

Remove stray println from rustfmt

25446c2

Rollup merge of rust-lang#126177 - carbotaniuman:unsafe_attr_errors, …

9a591ea

…r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

Rollup merge of rust-lang#126298 - heiher:loongarch64-musl-ci, r=Mark…

7babf99

…-Simulacrum Promote loongarch64-unknown-linux-musl to Tier 2 with host tools MCP: rust-lang/compiler-team#753 Tracking issue: rust-lang#122592 try-job: dist-loongarch64-musl

Rollup merge of rust-lang#126807 - devnexen:copy_file_macos_simpl, r=…

21850f5

…Mark-Simulacrum std::unix::fs: copy simplification for apple. since we do support from macOs Sierra, we avoid the little runtime overhead with the fclonefileat symbol check.

Rollup merge of rust-lang#126854 - devnexen:std_unix_os_fallback_upd,…

9892b3e

… r=Mark-Simulacrum std::unix::os::home_dir: fallback's optimisation. we're using a guaranteed initialised field on success.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2024

dtolnay mentioned this pull request Jun 24, 2024

Remove stray println from rustfmt's rewrite_static #126888

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2024

bors merged commit 2c243d9 into rust-lang:master Jun 24, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jun 24, 2024

This was referenced Jun 24, 2024

add unqualified_local_imports lint #125645

Merged

Make casts of pointers to trait objects stricter #120248

Merged

coverage: Make #[coverage(..)] apply recursively to nested functions #126721

Merged

matthiaskrgr deleted the rollup-p6dl1gk branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #126891

Rollup of 9 pull requests #126891

matthiaskrgr commented Jun 24, 2024

matthiaskrgr commented Jun 24, 2024

bors commented Jun 24, 2024

bors commented Jun 24, 2024

bors commented Jun 24, 2024

rust-timer commented Jun 24, 2024

rust-timer commented Jun 24, 2024

Rollup of 9 pull requests #126891

Rollup of 9 pull requests #126891

Conversation

matthiaskrgr commented Jun 24, 2024

matthiaskrgr commented Jun 24, 2024

bors commented Jun 24, 2024

bors commented Jun 24, 2024

bors commented Jun 24, 2024

rust-timer commented Jun 24, 2024

rust-timer commented Jun 24, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size