Clarify that anonymous consts still do introduce a new scope #126652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
cc @Urgau |
|
☔ The latest upstream changes (presumably #126655) made this pull request unmergeable. Please resolve the merge conflicts. |
Urgau
reviewed
Jun 19, 2024
|
LGTM with @Urgau's suggestion applied. |
Manishearth
force-pushed
the
anon-const-scope
branch
from
2804239 to
ab270a7
Compare
|
Applied. |
Manishearth
force-pushed
the
anon-const-scope
branch
from
ab270a7 to
e8a9af9
Compare
Urgau
approved these changes
Jun 20, 2024
|
@bors r=bjorn3,Urgau rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126649 (Fix `feature = "nightly"` in the new trait solver) - rust-lang#126652 (Clarify that anonymous consts still do introduce a new scope) - rust-lang#126703 (reword the hint::blackbox non-guarantees) - rust-lang#126708 (Minimize `can_begin_literal_maybe_minus` usage) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2024
Rollup merge of rust-lang#126652 - Manishearth:anon-const-scope, r=bjorn3,Urgau Clarify that anonymous consts still do introduce a new scope See rust-lang#120363 (comment) This error message is misleading: it's trying to say that `const _ : () = ...` is a workaround for the lint, but by saying that anonymous constants are treated as being in the parent scope, it makes them appear useless for scope-hiding. They *are* useful for scope-hiding, they are simply treated as part of the parent scope when it comes to this lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #120363 (comment)
This error message is misleading: it's trying to say that
const _ : () = ...is a workaround for the lint, but by saying that anonymous constants are treated as being in the parent scope, it makes them appear useless for scope-hiding.They are useful for scope-hiding, they are simply treated as part of the parent scope when it comes to this lint.