Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less bootstrap warnings #126616

Merged
merged 2 commits into from
Jun 23, 2024
Merged

less bootstrap warnings #126616

merged 2 commits into from
Jun 23, 2024

Commits on Jun 18, 2024

  1. replace remove_dir with remove_dir_all in helpers::symlink_dir 

    When using `symlink_dir`, it first removes the existing link with `remove_dir`.
However, if the path isn't a link and contains files, `remove_dir` fails
with "DirectoryNotEmpty", which causes the symbolic linking to fail as well.
We have this problem on linking 'rustlib/rust' because it contains files as an
actual directory.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
    @onur-ozkan
    onur-ozkan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f76c3b7 View commit details
    Browse the repository at this point in the history

  2. make codegen-backend config warning less noisy 

    If `codegen-backends` is missing "cranelift" and "gcc" (which is common),
bootstrap will now only show this warning during `dist` and `install` steps,
or if codegen-backends was explicitly called for build.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
    @onur-ozkan
    onur-ozkan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    521e707 View commit details
    Browse the repository at this point in the history