Skip to content

Rollup of 7 pull requests #126201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eb72938
Add FRAC_1_SQRT_2PI constant to f16/f32/f64/f128
sunsided May 22, 2024
54bb08d
Add FRAC_1_SQRT_2PI doc alias to FRAC_1_SQRT_TAU
sunsided May 29, 2024
fb6fbf0
Use FileCheck to parameterize codegen tests over hashes
workingjubilee Jun 4, 2024
8a0f195
docs: add README.md for build_helper
weihanglo May 23, 2024
021ccf6
Enable GVN for `AggregateKind::RawPtr` & `UnOp::PtrMetadata`
scottmcm May 12, 2024
fbe5015
Fix documentation for `impl_common_helpers` in `run-make-support`
Kobzol Jun 9, 2024
4977608
Add release notes for 1.79.0
cuviper May 24, 2024
e24be07
feat: vendor crates required by opt-dist to collect profiles
weihanglo May 23, 2024
3778703
tidy: add license exceptions for rustc-perf
weihanglo May 25, 2024
f2d707d
rustdoc-search: use lowercase, non-normalized name for type search
notriddle Jun 8, 2024
3a2854a
Rollup merge of #125041 - scottmcm:gvn-for-from-raw-parts, r=cjgillot
jieyouxu Jun 9, 2024
a13bb76
Rollup merge of #125253 - sunsided:feature/FRAC_1_SQRT_PI, r=Mark-Sim…
jieyouxu Jun 9, 2024
e97e2fc
Rollup merge of #125465 - weihanglo:opt-dist-vendor, r=Mark-Simulacrum
jieyouxu Jun 9, 2024
238ddca
Rollup merge of #125470 - cuviper:relnotes-1.79.0, r=Mark-Simulacrum
jieyouxu Jun 9, 2024
c1d01a6
Rollup merge of #125963 - workingjubilee:remove-hashes-from-codegen-t…
jieyouxu Jun 9, 2024
4f67f3c
Rollup merge of #126176 - notriddle:notriddle/fix-type-name-normalize…
jieyouxu Jun 9, 2024
0003d14
Rollup merge of #126188 - Kobzol:runmake-command-docs, r=jieyouxu
jieyouxu Jun 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use FileCheck to parameterize codegen tests over hashes
When things like our internal hashing or representations change,
it is inappropriate for these tests to suddenly fail for no reason.
The chance of error is reduced if we instead pattern-match.
  • Loading branch information
workingjubilee committed Jun 4, 2024
commit fb6fbf02a65ad1fc766aeee7c7698907d56f8e12
4 changes: 2 additions & 2 deletions tests/assembly/asm/global_asm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ global_asm!("movl ${}, %ecx", const 5, options(att_syntax));
global_asm!("call {}", sym my_func);
// CHECK: lea rax, [rip + MY_STATIC]
global_asm!("lea rax, [rip + {}]", sym MY_STATIC);
// CHECK: call _RNvCsddMtV7nAi4C_10global_asm6foobar
// CHECK: call _RNvC[[CRATE_IDENT:[a-zA-Z0-9]{12}]]_10global_asm6foobar
global_asm!("call {}", sym foobar);
// CHECK: _RNvCsddMtV7nAi4C_10global_asm6foobar:
// CHECK: _RNvC[[CRATE_IDENT]]_10global_asm6foobar:
fn foobar() {
loop {}
}
4 changes: 2 additions & 2 deletions tests/codegen/consts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
// CHECK: @STATIC = {{.*}}, align 4

// This checks the constants from inline_enum_const
// CHECK: @alloc_af1f8e8e6f4b341431a1d405e652df2d = {{.*}}, align 2
// CHECK: @alloc_[[INLINE_ENUM_HASH:[a-f0-9]{32}]] = {{.*}}, align 2

// This checks the constants from {low,high}_align_const, they share the same
// constant, but the alignment differs, so the higher one should be used
// CHECK: [[LOW_HIGH:@alloc_[a-f0-9]+]] = {{.*}}, align 4
// CHECK: [[LOW_HIGH:@alloc_[a-f0-9]{32}]] = {{.*}}, align 4

#[derive(Copy, Clone)]
// repr(i16) is required for the {low,high}_align_const test
Expand Down
4 changes: 2 additions & 2 deletions tests/codegen/pattern_type_symbols.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ fn foo<T>() {}

pub fn bar() {
// CHECK: call pattern_type_symbols::foo::<u32>
// CHECK: call void @_RINvCs3QvG2ESzx2Q_20pattern_type_symbols3foomEB2_
// CHECK: call void @_RINvC[[CRATE_IDENT:[a-zA-Z0-9]{12}]]_20pattern_type_symbols3foomEB2_
foo::<u32>();
// CHECK: call pattern_type_symbols::foo::<(u32, [(); 0], [(); 999999999], [(); true])>
// CHECK: call void @_RINvCs3QvG2ESzx2Q_20pattern_type_symbols3fooTmAum0_Aum3b9ac9ff_Aub1_EEB2_
// CHECK: call void @_RINvC[[CRATE_IDENT]]_20pattern_type_symbols3fooTmAum0_Aum3b9ac9ff_Aub1_EEB2_
foo::<NanoU32>();
}
4 changes: 2 additions & 2 deletions tests/codegen/virtual-function-elimination.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ fn taking_u(u: &dyn U) -> i32 {
}

pub fn taking_v(v: &dyn V) -> i32 {
// CHECK: @llvm.type.checked.load({{.*}}, i32 24, metadata !"NtCs64ITQYi9761_28virtual_function_elimination1V")
// CHECK: @llvm.type.checked.load({{.*}}, i32 24, metadata !"NtC[[CRATE_IDENT:[a-zA-Z0-9]{12}]]_28virtual_function_elimination1V")
v.public_function()
}

Expand All @@ -96,5 +96,5 @@ pub fn main() {
// CHECK: ![[TYPE0]] = !{i64 0, !"[[MANGLED_TYPE0]]"}
// CHECK: ![[VCALL_VIS0]] = !{i64 2}
// CHECK: ![[TYPE1]] = !{i64 0, !"[[MANGLED_TYPE1]]"}
// CHECK: ![[TYPE2]] = !{i64 0, !"NtCs64ITQYi9761_28virtual_function_elimination1V"}
// CHECK: ![[TYPE2]] = !{i64 0, !"NtC[[CRATE_IDENT]]_28virtual_function_elimination1V"}
// CHECK: ![[VCALL_VIS2]] = !{i64 1}