-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #126134
Rollup of 11 pull requests #126134
Conversation
Rayon's `try_for_each` makes the `CombinedEncoder` a lot simpler.
It has only two uses, and both use `matches_codepattern`. So just change it to `assert_matches_codepattern`.
It's small and has a single call site. Also change the second `parse_meta` call to use a simple `match`, like the first `parse_meta` call, instead of a confusing `map_err`+`ok` combination.
…hing will have a MIR body." This reverts commit e5cba17.
Previously, we were running bare commands for `ToolBuild` step and were unable to utilize some of the flags which are already handled by `compile::stream_cargo`. This change makes `ToolBuild` to use `compile::stream_cargo`, allowing us to benefit from the flags supported by the bootstrap cargo. Signed-off-by: onur-ozkan <work@onurozkan.dev>
…rntSushi Stabilize `binary_heap_as_slice` This PR stabilizes `binary_heap_as_slice`: ```rust // std::collections::BinaryHeap impl BinaryHeap<T> { pub fn as_slice(&self) -> &[T] } ``` <br> Tracking issue: rust-lang#83659. Implementation PR: rust-lang#82331. FCPs already completed in the tracking issue. Closes rust-lang#83659. r? libs-api
…r=michaelwoerister Parse unsafe attributes Initial parse implementation for rust-lang#123757 This is the initial work to parse unsafe attributes, which is represented as an extra `unsafety` field in `MetaItem` and `AttrItem`. There's two areas in the code where it appears that parsing is done manually and not using the parser stuff, and I'm not sure how I'm supposed to thread the change there.
…ouxu Clean up source root in run-make tests The name `S` isn't exactly the most descriptive, and we also shouldn't need to pass it when building (actually I think that most of the env. vars that we pass to `cargo` here are probably not really needed). Related issue: rust-lang#126071 r? ```@jieyouxu```
Improve docs for using custom paths with `--emit` Recently I found myself concluding that this feature didn't exist (rust-lang#126111 (comment)), despite having read the documentation, because it was hidden away in the middle of a paragraph full of other information. Giving this documentation more space of its own should make it easier to find.
@bors r+ rollup=never p=11 |
Please allow the queue to drain for #126114 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 4dc24ae394 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (804421d): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.1%, secondary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: missing data |
@rust-timer build c137109 |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (c137109): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDInstruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
Successful merges:
binary_heap_as_slice
#124012 (Stabilizebinary_heap_as_slice
)compile::stream_cargo
for building tools #125781 (prefercompile::stream_cargo
for building tools)./x fmt
command in library/std/src/sys/pal/windows/c/README.md #126030 (Update./x fmt
command in library/std/src/sys/pal/windows/c/README.md)rustc_parse
cleanups #126052 (Morerustc_parse
cleanups)--emit
#126119 (Improve docs for using custom paths with--emit
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup