std::unix::fs::get_path: using fcntl codepath for netbsd instead.#125940
Merged
Conversation
Collaborator
rustbot
added
O-unix
Contributor
|
Perhaps it could fall back to the proc fs code path in case of |
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
devnexen
force-pushed
the
unix_fs_netbsd_get_path
branch
from
6bcaac3 to
e41e233
Compare
cuviper
reviewed
Jun 4, 2024
| // fallback to procfs as last resort | ||
| let mut p = PathBuf::from("/proc/self/fd"); | ||
| p.push(&fd.to_string()); | ||
| if p.exists() { |
Member
There was a problem hiding this comment.
Why do you need to check p.exists()? It seems to just add extra syscalls. If the path doesn't exist, I expect readlink will get an error anyway, which ok() will turn to None just like the fallthrough below.
on netbsd, procfs is not as central as on linux/solaris thus can be perfectly not mounted. Thus using fcntl with F_GETPATH, the kernel deals with MAXPATHLEN internally too.
devnexen
force-pushed
the
unix_fs_netbsd_get_path
branch
from
e41e233 to
fd648a3
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on netbsd, procfs is not as central as on linux/solaris thus can be perfectly not mounted.
Thus using fcntl with F_GETPATH, the kernel deals with MAXPATHLEN internally too.