Migrate run-make/issue-46239 to rmake#125222
Conversation
rustbot
added
A-testsuite
|
Some changes occurred in run-make tests. cc @jieyouxu |
|
The run-make-support library was changed cc @jieyouxu |
| @@ -0,0 +1,14 @@ | |||
| // In the rustc_trans crate, references returned by a Frozen pointer type | |||
There was a problem hiding this comment.
This comment is outdated, we don't have a rustc_trans crate anymore do we?
| @@ -0,0 +1,14 @@ | |||
| // In the rustc_trans crate, references returned by a Frozen pointer type | |||
| // could mark them as "noalias", which caused miscompilation errors. | |||
There was a problem hiding this comment.
I feel this should be a codegen test if we're trying to check for noalias metadata?
|
I'll revisit this, this seems like it should be a codegen test |
|
See codegen tests for more references, please do ask me if you are stuck or have any questions. @rustbot author |
rustbot
added
S-waiting-on-author
|
I have attempted the conversion to a codegen test, more so we can discuss it than claim "it's done". Seeing the other tests putting their flags on library functions and not @rustbot review |
rustbot
added
S-waiting-on-review
| // CHECK-NOT: noalias | ||
| fn main() { | ||
| let f = (dummy as fn(),); | ||
| (*project(&f))(); | ||
| } |
There was a problem hiding this comment.
Suggestion: I think this test could be written as
//@ compile-flags: -Copt-level=1
#![crate_type = "lib"]
fn project<T>(x: &(T,)) -> &T { &x.0 }
fn dummy() {}
// CHECK-LABEL: @foo(
// CHECK-NOT: noalias
#[no_mangle]
pub fn foo() {
let f = (dummy as fn(),);
(*project(&f))();
}This way the noalias check must happen after the foo label occurs.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
@rustbot review Thanks for the suggestion! I'm just now learning how the codegen tests work, and I see how you made it more similar to the other codegen tests, and prevented the name |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Thanks, r=me after squashing commits into one. |
|
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#123623 (Fix OutsideLoop's error suggestion: adding label `'block` for `if` block.) - rust-lang#125054 (Handle `ReVar` in `note_and_explain_region`) - rust-lang#125156 (Expand `for_loops_over_fallibles` lint to lint on fallibles behind references.) - rust-lang#125222 (Migrate `run-make/issue-46239` to `rmake`) - rust-lang#125316 (Tweak `Spacing` use) - rust-lang#125392 (Wrap Context.ext in AssertUnwindSafe) - rust-lang#125417 (self-contained linker: retry linking without `-fuse-ld=lld` on CCs that don't support it) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125222 - Oneirical:fifth, r=jieyouxu Migrate `run-make/issue-46239` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
5 participants
Part of #121876 and the associated Google Summer of Code project.