Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record impl args in the proof tree #124718

Merged
merged 1 commit into from
May 4, 2024

Conversation

compiler-errors
Copy link
Member

Weren't recording these since they went through a different infcx method

r? lcnr

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 4, 2024
--> $DIR/point-at-failing-nested.rs:22:17
|
LL | needs_foo::<()>();
| ^^ the trait `Bar` is not implemented for `()`, which is required by `(): Foo`
Copy link
Member Author

@compiler-errors compiler-errors May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to say:

the trait Sized is not implemented for ()

which is obviously incorrect, but due to ?0: Sized being a nested goal.

This wouldve been fixed by #124690, but then we wouldn't be reporting a nested goal as the failure cause at all.

@lcnr
Copy link
Contributor

lcnr commented May 4, 2024

r=me after CI

@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup

@bors
Copy link
Contributor

bors commented May 4, 2024

📌 Commit 50338aa has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#124501 (add support to override lldb binary path for ./x test)
 - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".)
 - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally)
 - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities)
 - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg)
 - rust-lang#124717 (Implement `do_not_recommend` in the new solver)
 - rust-lang#124718 (Record impl args in the proof tree)
 - rust-lang#124720 (interpret: Drop: always evaluate place)
 - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`)
 - rust-lang#124723 (Use correct Hermit links in The `rustc` Book)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07dc4aa into rust-lang:master May 4, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2024
Rollup merge of rust-lang#124718 - compiler-errors:record-impl-args, r=lcnr

Record impl args in the proof tree

Weren't recording these since they went through a different infcx method

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants